Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1464)

Issue 10639019: Disable SyncHttpBridgeTest.* unit tests for Android (Closed)

Created:
8 years, 6 months ago by Jesse Greenwald
Modified:
8 years, 6 months ago
Reviewers:
Yaron, nilesh
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Disable SyncHttpBridgeTest.* unit tests for Android These tests were moved into sync unitests by r143575. However, these tests don't work on Android. BUG=133791 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=143681

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
A build/android/gtest_filter/sync_unit_tests_disabled View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
Jesse Greenwald
yaron, nilesh - this should fix the failing fyi bot: https://chromiumcodereview.appspot.com/10639019
8 years, 6 months ago (2012-06-22 18:23:40 UTC) #1
nilesh
On 2012/06/22 18:23:40, jgreenwald1 wrote: > yaron, nilesh - this should fix the failing fyi ...
8 years, 6 months ago (2012-06-22 18:26:39 UTC) #2
Yaron
lgtm
8 years, 6 months ago (2012-06-22 18:26:43 UTC) #3
nilesh
http://codereview.chromium.org/10639019/diff/1/build/android/gtest_filter/sync_unit_tests_disabled File build/android/gtest_filter/sync_unit_tests_disabled (right): http://codereview.chromium.org/10639019/diff/1/build/android/gtest_filter/sync_unit_tests_disabled#newcode1 build/android/gtest_filter/sync_unit_tests_disabled:1: SyncHttpBridgeTest.* Please add a comment that the test needs ...
8 years, 6 months ago (2012-06-22 18:26:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jgreenwald@chromium.org/10639019/1
8 years, 6 months ago (2012-06-22 18:30:23 UTC) #5
commit-bot: I haz the power
8 years, 6 months ago (2012-06-22 19:39:30 UTC) #6
Change committed as 143681

Powered by Google App Engine
This is Rietveld 408576698