Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Unified Diff: content/public/app/startup_helper_win.h

Issue 10638010: Undo the startup_helper_win.h change in r143501 because that breaks the sandbox in component builds. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/content_tests.gypi ('k') | ui/views/views.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/app/startup_helper_win.h
===================================================================
--- content/public/app/startup_helper_win.h (revision 143501)
+++ content/public/app/startup_helper_win.h (working copy)
@@ -6,8 +6,6 @@
#define CONTENT_PUBLIC_APP_STARTUP_HELPER_WIN_H_
#pragma once
-#include "content/common/content_export.h"
-
class CommandLine;
namespace sandbox {
@@ -16,13 +14,15 @@
// This file contains functions that any embedder that's not using ContentMain
// will want to call at startup.
+// NOTE: we never want to CONTENT_EXPORT these functions, they must run in the
+// same module that calls them.
namespace content {
// Initializes the sandbox code and turns on DEP. Note: This function
// must be *statically* linked into the executable (along with the static
// sandbox library); it will not work correctly if it is exported from a
// DLL and linked in.
-CONTENT_EXPORT void InitializeSandboxInfo(
+void InitializeSandboxInfo(
sandbox::SandboxInterfaceInfo* sandbox_info);
// Register the invalid param handler and pure call handler to be able to
« no previous file with comments | « content/content_tests.gypi ('k') | ui/views/views.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698