Issue 10638010: Undo the startup_helper_win.h change in r143501 because that breaks the sandbox in component builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10638010: Undo the startup_helper_win.h change in r143501 because that breaks the sandbox in component builds. (Closed)

Created:
8 years, 6 months ago by jam

Modified:
8 years, 6 months ago

Reviewers:
scottmg

CC:
chromium-reviews, sadrul, jochen+watch-content_chromium.org, ben+watch_chromium.org, tfarina, jam, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Undo the startup_helper_win.h change in r143501 because that breaks the sandbox in component builds. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143515

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -3 lines)			Patch
M	ash/ash.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1	6 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/test/gpu/test_support_gpu.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/content_shell.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/content_tests.gypi	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	content/public/app/startup_helper_win.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	ui/views/views.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages