Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 10637009: Browser Plugin: Disable context menu on guests (Closed)

Created:
8 years, 6 months ago by Fady Samuel
Modified:
8 years, 6 months ago
Reviewers:
Charlie Reis, jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org
Visibility:
Public.

Description

Browser Plugin: Disable context menu on guests BUG=134195 TEST=manually Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=143720

Patch Set 1 #

Total comments: 3

Patch Set 2 : Updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M content/renderer/render_view_impl.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Fady Samuel
Hi Charlie, Does this look like a reasonable fix for the context menu issue you ...
8 years, 6 months ago (2012-06-22 19:13:21 UTC) #1
Charlie Reis
Please file a bug and cite it in the change description. This is good practice ...
8 years, 6 months ago (2012-06-22 19:55:23 UTC) #2
Fady Samuel
+jam@ for OWNER review. Thanks :-) https://chromiumcodereview.appspot.com/10637009/diff/1/content/renderer/render_view_impl.cc File content/renderer/render_view_impl.cc (right): https://chromiumcodereview.appspot.com/10637009/diff/1/content/renderer/render_view_impl.cc#newcode2008 content/renderer/render_view_impl.cc:2008: return; On 2012/06/22 ...
8 years, 6 months ago (2012-06-22 20:03:43 UTC) #3
jam
lgtm http://codereview.chromium.org/10637009/diff/1/content/renderer/render_view_impl.cc File content/renderer/render_view_impl.cc (right): http://codereview.chromium.org/10637009/diff/1/content/renderer/render_view_impl.cc#newcode2006 content/renderer/render_view_impl.cc:2006: // decide whether the guest can show a ...
8 years, 6 months ago (2012-06-22 20:43:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/10637009/7001
8 years, 6 months ago (2012-06-22 20:50:06 UTC) #5
commit-bot: I haz the power
8 years, 6 months ago (2012-06-22 22:02:46 UTC) #6
Change committed as 143720

Powered by Google App Engine
This is Rietveld 408576698