Browser Plugin: Disable context menu on guests

Browser Plugin: Disable context menu on guests

BUG=134195
TEST=manually

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=143720

[Fady Samuel, 2012-06-22 19:13:21]

Hi Charlie,

Does this look like a reasonable fix for the context menu issue you mentioned
until we design/develop a context menu API?

Thanks,

Fady

[Charlie Reis, 2012-06-22 19:55:23]

Please file a bug and cite it in the change description.  This is good practice
in general, and it will help if we need to revert this for any reason.

I think this is reasonable until we have a way to customize context menus for
the embedder.  For example, "Open Link in New Tab" probably needs to be handled
in a different way.

LGTM.

https://chromiumcodereview.appspot.com/10637009/diff/1/content/renderer/rende...
File content/renderer/render_view_impl.cc (right):

https://chromiumcodereview.appspot.com/10637009/diff/1/content/renderer/rende...
content/renderer/render_view_impl.cc:2008: return;
I'm not 100% sure that the renderer isn't expecting some kind of reply from
this, but I think it's ok.

[Fady Samuel, 2012-06-22 20:03:43]

+jam@ for OWNER review. Thanks :-)

https://chromiumcodereview.appspot.com/10637009/diff/1/content/renderer/rende...
File content/renderer/render_view_impl.cc (right):

https://chromiumcodereview.appspot.com/10637009/diff/1/content/renderer/rende...
content/renderer/render_view_impl.cc:2008: return;
On 2012/06/22 19:55:23, creis wrote:
> I'm not 100% sure that the renderer isn't expecting some kind of reply from
> this, but I think it's ok.

OK. This seems to work OK. A good fix with an API will take longer but this way
avoids the crash and invalid options like "Open Link in New Window" until we
have an API.

[jam, 2012-06-22 20:43:05]

lgtm

http://codereview.chromium.org/10637009/diff/1/content/renderer/render_view_i...
File content/renderer/render_view_impl.cc (right):

http://codereview.chromium.org/10637009/diff/1/content/renderer/render_view_i...
content/renderer/render_view_impl.cc:2006: // decide whether the guest can show
a context menu or not.
nit: put the bug number here

[commit-bot: I haz the power, 2012-06-22 20:50:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fsamuel@chromium.org/10637009/7001

[commit-bot: I haz the power, 2012-06-22 22:02:46]

Change committed as 143720