Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 10636057: Port r11517 (not deopt Math.floor on negative input) to x64, sse2. (Closed)

Created:
8 years, 6 months ago by Yang
Modified:
8 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Port r11517 (not deopt Math.floor on negative input) to x64, sse2. BUG=v8:873 TEST=math-floor-negative.js Committed: https://code.google.com/p/v8/source/detail?r=11935

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -25 lines) Patch
M src/ia32/lithium-codegen-ia32.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M src/x64/assembler-x64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 3 chunks +17 lines, -4 lines 0 comments Download
A + test/mjsunit/math-floor-negative.js View 1 chunk +23 lines, -17 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Yang
Based on https://chromiumcodereview.appspot.com/10168001. PTAL.
8 years, 6 months ago (2012-06-26 16:57:30 UTC) #1
Jakob Kummerow
8 years, 6 months ago (2012-06-26 17:27:48 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698