Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issue 10168001: Handle negative number in Math.floor,ia32,non-SSE4.1 code path. (Closed)

Created:
8 years, 8 months ago by Zheng Liu
Modified:
8 years, 7 months ago
Reviewers:
fschneider, Yang
CC:
v8-dev, zheng.z.liu
Visibility:
Public.

Description

Handle negative number in Math.floor,ia32,non-SSE4.1 code path. Zheng Liu zheng.z.liu@intel.com Committed: https://code.google.com/p/v8/source/detail?r=11517

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M src/ia32/lithium-codegen-ia32.cc View 2 chunks +16 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Zheng Liu
Please help review this patch. Thanks.
8 years, 8 months ago (2012-04-20 09:41:53 UTC) #1
Yang
On 2012/04/20 09:41:53, Zheng Liu wrote: > Please help review this patch. Thanks. Thanks for ...
8 years, 8 months ago (2012-04-20 11:43:55 UTC) #2
Zheng Liu
On 2012/04/20 11:43:55, Yang wrote: > If you are contributing on behalf of Intel, you ...
8 years, 8 months ago (2012-04-20 21:43:41 UTC) #3
Yang
On 2012/04/20 21:43:41, Zheng Liu wrote: > On 2012/04/20 11:43:55, Yang wrote: > > If ...
8 years, 8 months ago (2012-04-25 08:44:35 UTC) #4
Yang
8 years, 7 months ago (2012-05-04 15:51:21 UTC) #5
On 2012/04/25 08:44:35, Yang wrote:
> On 2012/04/20 21:43:41, Zheng Liu wrote:
> > On 2012/04/20 11:43:55, Yang wrote:
> > > If you are contributing on behalf of Intel, you will need to
> > > update the authorized contributors list in the corporate CLA
> > > (http://code.google.com/legal/corporate-cla-v1.0.html) as I haven't found
> your
> > > email address in that list.
> > 
> > I'm contributing on behalf of Intel as mailto:zheng.z.liu@intel.com
> > I've notified the Intel stakeholder to update CCLA, and I'll update the
status
> > when it's done. (Probably sometime next week)
> > 
> > Thanks for your help and sorry for the delay of CCLA update.
> > 
> > Zheng Liu
> > mailto:zheng.z.liu@intel.com
> 
> Any update on the CLA yet?

Landed as r11517.

Powered by Google App Engine
This is Rietveld 408576698