Convert runtest to have a built-in annotator.

Convert runtest to have a built-in annotator.
This is currently unused, a
future CL will convert GTestCommand to an annotator step that uses this
addition.

Note: it appears asan tests uses the 'pipes' facility of RunCommand which
is currently incompatible with any parsers. This will have to be addressed
for annotation functionality for these tests.

BUG=
TEST=
R=cmp@chromium.org, nsylvain@chromium.org


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146151

[cmp, 2012-06-28 19:14:16]

here are some initial comments

https://chromiumcodereview.appspot.com/10636008/diff/1/scripts/common/gtest_u...
File scripts/common/gtest_utils.py (right):

https://chromiumcodereview.appspot.com/10636008/diff/1/scripts/common/gtest_u...
scripts/common/gtest_utils.py:171: 
nit: remove empty line

https://chromiumcodereview.appspot.com/10636008/diff/1/scripts/common/gtest_u...
scripts/common/gtest_utils.py:179: return True
let's condense lines 172-179 to one line:
  return self.completed and not self.FailedTests()

https://chromiumcodereview.appspot.com/10636008/diff/1/scripts/slave/runtest.py
File scripts/slave/runtest.py (right):

https://chromiumcodereview.appspot.com/10636008/diff/1/scripts/slave/runtest....
scripts/slave/runtest.py:40: from common import chromium_utils
insert an empty line before line 40

https://chromiumcodereview.appspot.com/10636008/diff/1/scripts/slave/runtest....
scripts/slave/runtest.py:194: 
nit: insert an empty line

https://chromiumcodereview.appspot.com/10636008/diff/1/scripts/slave/runtest....
scripts/slave/runtest.py:195: def getText(result, observer, name):
please add a heredoc with a summary of this method's purpose

https://chromiumcodereview.appspot.com/10636008/diff/1/scripts/slave/runtest....
scripts/slave/runtest.py:236: 
nit: insert an empty line

https://chromiumcodereview.appspot.com/10636008/diff/1/scripts/slave/runtest....
scripts/slave/runtest.py:237: def annotate(test_name, result, results_tracker):
please add a heredoc with a summary of this method's purpose

[cmp, 2012-06-28 20:59:08]

Here are the last comments I have for this patchset.

Chris was the last to move this code out (and that explains why I thought it was
still just in scripts/master :) ), so I'm adding him to the cc line.  Chris,
feel free to take a look.

https://chromiumcodereview.appspot.com/10636008/diff/1/scripts/slave/runtest.py
File scripts/slave/runtest.py (right):

https://chromiumcodereview.appspot.com/10636008/diff/1/scripts/slave/runtest....
scripts/slave/runtest.py:195: def getText(result, observer, name):
On 2012/06/28 19:14:16, cmp wrote:
> please add a heredoc with a summary of this method's purpose

just checking: is this only used by the annotate() method below?

https://chromiumcodereview.appspot.com/10636008/diff/1/scripts/slave/runtest....
scripts/slave/runtest.py:196: GTEST_DASHBOARD_BASE =
("http://test-results.appspot.com"
nit: single quotes here and on line 197

https://chromiumcodereview.appspot.com/10636008/diff/1/scripts/slave/runtest....
scripts/slave/runtest.py:199: basic_info = [name]
can you add a comment before line 199 describing what basic_info is/how it's
used by buildbot or the annotator?

[Mike Stip (use stip instead), 2012-07-11 00:10:41]

http://chromiumcodereview.appspot.com/10636008/diff/1/scripts/slave/runtest.py
File scripts/slave/runtest.py (right):

http://chromiumcodereview.appspot.com/10636008/diff/1/scripts/slave/runtest.p...
scripts/slave/runtest.py:195: def getText(result, observer, name):
yes, look at getText() in scripts/master/log_parser/gtest_command.py

On 2012/06/28 20:59:08, cmp wrote:
> On 2012/06/28 19:14:16, cmp wrote:
> > please add a heredoc with a summary of this method's purpose
> 
> just checking: is this only used by the annotate() method below?

[cmp, 2012-07-11 17:29:06]

lgtm

[commit-bot: I haz the power, 2012-07-11 18:25:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xusydoc@chromium.org/10636008/7001

[commit-bot: I haz the power, 2012-07-11 18:26:49]

Change committed as 146151