Adding config step to output the bisect config dictionary.

Adding config step to output the bisect config dictionary.


R=qyearsley@chromium.org, prasadv@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294691

[RobertoCN, 2015-04-03 22:44:26]

How does this look?

I am now tracking the appropriate branch.

[qyearsley, 2015-04-03 23:20:22]

https://codereview.chromium.org/1062583003/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/auto_bisect/bisector.py (right):

https://codereview.chromium.org/1062583003/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/auto_bisect/bisector.py:32: api.m.step('config',
['echo', str(dict(bisect_config))])
Config step text would be easier to visually parse if it were formatted &
indented.

pprint.pformat(bisect_config, indent=2, width=70)

or

json.dumps(bisect_config, indent=2)

[RobertoCN, 2015-04-03 23:26:13]

On 2015/04/03 23:20:22, qyearsley wrote:
>
https://codereview.chromium.org/1062583003/diff/1/scripts/slave/recipe_module...
> File scripts/slave/recipe_modules/auto_bisect/bisector.py (right):
> 
>
https://codereview.chromium.org/1062583003/diff/1/scripts/slave/recipe_module...
> scripts/slave/recipe_modules/auto_bisect/bisector.py:32: api.m.step('config',
> ['echo', str(dict(bisect_config))])
> Config step text would be easier to visually parse if it were formatted &
> indented.
> 
> pprint.pformat(bisect_config, indent=2, width=70)
> 
> or
> 
> json.dumps(bisect_config, indent=2)

Done

[qyearsley, 2015-04-03 23:47:48]

LGTM I think; I'm still not really sure whether it will behave as expected in
all cases, since I don't know how the command will be run by api.m.step; but if
doesn't work correctly in some case, then we'll certainly find out, right?

https://chromiumcodereview.appspot.com/1062583003/diff/20001/scripts/slave/re...
File scripts/slave/recipe_modules/auto_bisect/bisector.py (right):

https://chromiumcodereview.appspot.com/1062583003/diff/20001/scripts/slave/re...
scripts/slave/recipe_modules/auto_bisect/bisector.py:33: api.m.step('config',
['echo', json.dumps(dict(bisect_config), indent=2)])
Would it make any difference if you remove dict(), i.e. change it to the
following?
api.m.step('config', ['echo', json.dumps(bisect_config, indent=2)])

[RobertoCN, 2015-04-04 00:40:48]

PTAL, made some 'improvements'.

https://chromiumcodereview.appspot.com/1062583003/diff/1/scripts/slave/recipe...
File scripts/slave/recipe_modules/auto_bisect/bisector.py (right):

https://chromiumcodereview.appspot.com/1062583003/diff/1/scripts/slave/recipe...
scripts/slave/recipe_modules/auto_bisect/bisector.py:32: api.m.step('config',
['echo', str(dict(bisect_config))])
On 2015/04/03 23:20:22, qyearsley wrote:
> Config step text would be easier to visually parse if it were formatted &
> indented.
> 
> pprint.pformat(bisect_config, indent=2, width=70)
> 
> or
> 
> json.dumps(bisect_config, indent=2)

Done.

https://chromiumcodereview.appspot.com/1062583003/diff/20001/scripts/slave/re...
File scripts/slave/recipe_modules/auto_bisect/bisector.py (right):

https://chromiumcodereview.appspot.com/1062583003/diff/20001/scripts/slave/re...
scripts/slave/recipe_modules/auto_bisect/bisector.py:33: api.m.step('config',
['echo', json.dumps(dict(bisect_config), indent=2)])
On 2015/04/03 23:47:48, qyearsley wrote:
> Would it make any difference if you remove dict(), i.e. change it to the
> following?
> api.m.step('config', ['echo', json.dumps(bisect_config, indent=2)])

The cast is needed because data is passed as a non-serializable FrozenDict.

Please review the latest patchset.

[qyearsley, 2015-04-04 01:33:25]

On 2015/04/04 00:40:48, robertocn wrote:
> PTAL, made some 'improvements'.
> 
>
https://chromiumcodereview.appspot.com/1062583003/diff/1/scripts/slave/recipe...
> File scripts/slave/recipe_modules/auto_bisect/bisector.py (right):
> 
>
https://chromiumcodereview.appspot.com/1062583003/diff/1/scripts/slave/recipe...
> scripts/slave/recipe_modules/auto_bisect/bisector.py:32: api.m.step('config',
> ['echo', str(dict(bisect_config))])
> On 2015/04/03 23:20:22, qyearsley wrote:
> > Config step text would be easier to visually parse if it were formatted &
> > indented.
> > 
> > pprint.pformat(bisect_config, indent=2, width=70)
> > 
> > or
> > 
> > json.dumps(bisect_config, indent=2)
> 
> Done.
> 
>
https://chromiumcodereview.appspot.com/1062583003/diff/20001/scripts/slave/re...
> File scripts/slave/recipe_modules/auto_bisect/bisector.py (right):
> 
>
https://chromiumcodereview.appspot.com/1062583003/diff/20001/scripts/slave/re...
> scripts/slave/recipe_modules/auto_bisect/bisector.py:33: api.m.step('config',
> ['echo', json.dumps(dict(bisect_config), indent=2)])
> On 2015/04/03 23:47:48, qyearsley wrote:
> > Would it make any difference if you remove dict(), i.e. change it to the
> > following?
> > api.m.step('config', ['echo', json.dumps(bisect_config, indent=2)])
> 
> The cast is needed because data is passed as a non-serializable FrozenDict.
> 
> Please review the latest patchset.

Arr, I see. Latest patchset LGTM.

[RobertoCN, 2015-04-04 07:23:56]

The CQ bit was checked by robertocn@chromium.org

[commit-bot: I haz the power, 2015-04-04 07:24:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1062583003/60001

[commit-bot: I haz the power, 2015-04-04 07:26:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-04 07:26:37]

Presubmit check for 1062583003-60001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
tests/masters_test.py (63.33s) failed
1 masters failed:
master.chromiumos.tryserver
64 masters succeeded, 1 failed, 0 skipped in 63.1s.

=== Error running master.chromiumos.tryserver === 
Didn't find open port for master.chromiumos.tryserver


Missing LGTM from an OWNER for these files:
   
build/scripts/slave/recipes/bisect_test/example_bisect_results.expected/aborted_non_telemetry_test.json
   
build/scripts/slave/recipes/bisect_test/example_bisect_results.expected/basic_test.json
   
build/scripts/slave/recipes/bisect_test/example_bisect_results.expected/failed_direction_test.json
   
build/scripts/slave/recipes/bisect_test/example_bisect_results.expected/failed_test.json

Presubmit checks took 134.9s to calculate.

[RobertoCN, 2015-04-06 00:01:36]

The CQ bit was checked by robertocn@chromium.org

[commit-bot: I haz the power, 2015-04-06 00:01:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1062583003/60001

[commit-bot: I haz the power, 2015-04-06 00:04:20]

Committed patchset #4 (id:60001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294691