lib/compiler/implementation/ssa/nodes.dart - Issue 10624003: Relax the type requirements for using the builtin bitops.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/ssa/nodes.dart

Issue 10624003: Relax the type requirements for using the builtin bitops. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/compiler/implementation/ssa/nodes.dart

diff --git a/lib/compiler/implementation/ssa/nodes.dart b/lib/compiler/implementation/ssa/nodes.dart

index 75d703ee962c63315932ed0bc752e9040a2c208c..4ef67cb128b86261867f62ff8f757fd717946b61 100644

--- a/lib/compiler/implementation/ssa/nodes.dart

+++ b/lib/compiler/implementation/ssa/nodes.dart

@@ -1524,7 +1524,7 @@ class HBinaryBitOp extends HBinaryArithmetic {

HBinaryBitOp(HStatic target, HInstruction left, HInstruction right)

: super(target, left, right);

- bool get builtin() => left.isInteger() && right.isInteger();

+ bool get builtin() => left.isNumber() && right.isNumber();

kasperl 2012/06/21 08:58:29 Can we just remove the method and use the one in H

Mads Ager (google) 2012/06/21 10:25:31 Of course. Thanks!

HType computeTypeFromInputTypes() {

// All bitwise operations on primitive types either produce an

« no previous file with comments | « no previous file | no next file » | no next file with comments »