Relax the type requirements for using the builtin bitops.

lib/compiler/implementation/ssa/nodes.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 interface HVisitor<R> {
   R visitAdd(HAdd node);
   R visitBitAnd(HBitAnd node);
   R visitBitNot(HBitNot node);
   R visitBitOr(HBitOr node);
   R visitBitXor(HBitXor node);
@@ skipping 1506 matching lines @@
   bool dataEquals(HInstruction other) => true;
 }
 
 
 // TODO(floitsch): Should HBinaryArithmetic really be the super class of
 // HBinaryBitOp?
 class HBinaryBitOp extends HBinaryArithmetic {
   HBinaryBitOp(HStatic target, HInstruction left, HInstruction right)
       : super(target, left, right);
 
-  bool get builtin() => left.isInteger() && right.isInteger();
+  bool get builtin() => left.isNumber() && right.isNumber();

[kasperl, 2012/06/21 08:58:29]

Can we just remove the method and use the one in HBinaryArithmetic instead?

[Mads Ager (google), 2012/06/21 10:25:31]

Of course. Thanks!

 
   HType computeTypeFromInputTypes() {
     // All bitwise operations on primitive types either produce an
     // integer or throw an error.
     if (left.isPrimitive()) return HType.INTEGER;
     return HType.UNKNOWN;
   }
 
   HType computeDesiredTypeForNonTargetInput(HInstruction input) {
     // If the outgoing type should be a number we can get that only if both
@@ skipping 1084 matching lines @@
   HBasicBlock get start() => expression.start;
   HBasicBlock get end() {
     // We don't create a switch block if there are no cases.
     assert(!statements.isEmpty());
     return statements.last().end;
   }
 
   bool accept(HStatementInformationVisitor visitor) =>
       visitor.visitSwitchInfo(this);
 }