- Fix the barrier code when low bits of Smi are zeroes.

runtime/vm/assembler_ia32_test.cc

Index: runtime/vm/assembler_ia32_test.cc
===================================================================
--- runtime/vm/assembler_ia32_test.cc	(revision 8929)
+++ runtime/vm/assembler_ia32_test.cc	(working copy)
@@ -1862,7 +1862,7 @@
       GrowableObjectArray::New(old_array, Heap::kOld));
   const GrowableObjectArray& grow_new_array = GrowableObjectArray::Handle(
       GrowableObjectArray::New(old_array, Heap::kNew));
-  const Smi& smi = Smi::Handle(Smi::New(7));
+  Smi& smi = Smi::Handle();
   const Context& ctx = Context::Handle(Context::New(0));
 
   EXPECT(old_array.raw() == grow_old_array.data());
@@ -1874,12 +1874,15 @@
       reinterpret_cast<uword>(grow_new_array.raw()) +
       GrowableObjectArray::data_offset() - kHeapObjectTag));
 
-  // Store Smi into the old object.
-  test_code(ctx.raw(), smi.raw(), grow_old_array.raw());
-  EXPECT(reinterpret_cast<RawArray*>(smi.raw()) == grow_old_array.data());
-  EXPECT(!Isolate::Current()->store_buffer()->Contains(
-      reinterpret_cast<uword>(grow_old_array.raw()) +
-      GrowableObjectArray::data_offset() - kHeapObjectTag));
+  // Store Smis into the old object.
+  for (int i = -32; i < 32; i++) {

[cshapiro, 2012/06/20 20:36:11]

You probably want to check all of the values in the range of the test imm8
instruction.

+    smi = Smi::New(i);
+    test_code(ctx.raw(), smi.raw(), grow_old_array.raw());
+    EXPECT(reinterpret_cast<RawArray*>(smi.raw()) == grow_old_array.data());
+    EXPECT(!Isolate::Current()->store_buffer()->Contains(
+        reinterpret_cast<uword>(grow_old_array.raw()) +
+        GrowableObjectArray::data_offset() - kHeapObjectTag));
+  }
 
   // Store an old object into the old object.
   test_code(ctx.raw(), old_array.raw(), grow_old_array.raw());