Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1742)

Unified Diff: runtime/vm/assembler_ia32.cc

Issue 10592023: - Fix the barrier code when low bits of Smi are zeroes. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/assembler_ia32_test.cc » ('j') | runtime/vm/assembler_ia32_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_ia32.cc
===================================================================
--- runtime/vm/assembler_ia32.cc (revision 8929)
+++ runtime/vm/assembler_ia32.cc (working copy)
@@ -1393,6 +1393,7 @@
// required when storing a smi or an old object.
testl(value, Immediate(kNewObjectAlignmentOffset | kHeapObjectTag));
j(PARITY_ODD, &done, Assembler::kNearJump);
+ j(ZERO, &done, Assembler::kNearJump);
// Check that 'object' is an old object. A store buffer update is
// not required when storing into a new object.
testl(object, Immediate(kNewObjectAlignmentOffset));
« no previous file with comments | « no previous file | runtime/vm/assembler_ia32_test.cc » ('j') | runtime/vm/assembler_ia32_test.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698