Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(914)

Unified Diff: runtime/vm/dart_api_impl_test.cc

Issue 10584044: Check that the C string passed to Dart_NewString is valid UTF-8. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/dart_api_impl_test.cc
diff --git a/runtime/vm/dart_api_impl_test.cc b/runtime/vm/dart_api_impl_test.cc
index 2654e7ae270340b7cf56daf4a9e33c5773cc6027..73096ca7aaabce7fff3c9460fcc96e5bfb76259b 100644
--- a/runtime/vm/dart_api_impl_test.cc
+++ b/runtime/vm/dart_api_impl_test.cc
@@ -563,6 +563,27 @@ TEST_CASE(IsString) {
}
+TEST_CASE(NewString) {
+ const char* ascii = "string";
+ Dart_Handle ascii_str = Dart_NewString(ascii);
+ EXPECT_VALID(ascii_str);
+ EXPECT(Dart_IsString(ascii_str));
+
+ const char* null = NULL;
+ Dart_Handle null_str = Dart_NewString(null);
+ EXPECT(Dart_IsError(null_str));
+
+ const char* utf8 = "\xE4\xBA\x8C"; // U+4E8C
+ Dart_Handle utf8_str = Dart_NewString(utf8);
+ EXPECT_VALID(utf8_str);
+ EXPECT(Dart_IsString(utf8_str));
+
+ const char* invalid = "\xE4\xBA"; // underflow
+ Dart_Handle invalid_str = Dart_NewString(invalid);
+ EXPECT(Dart_IsError(invalid_str));
+}
+
+
TEST_CASE(ExternalStringGetPeer) {
Dart_Handle result;

Powered by Google App Engine
This is Rietveld 408576698