Check that the C string passed to Dart_NewString is valid UTF-8.

runtime/vm/dart_api_impl_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "platform/utils.h"
 #include "vm/class_finalizer.h"
 #include "vm/dart_api_impl.h"
 #include "vm/dart_api_state.h"
@@ skipping 545 matching lines @@
   Dart_Handle ext32 = Dart_NewExternalString32(data32, ARRAY_SIZE(data32),
                                                NULL, NULL);
   EXPECT_VALID(ext32);
   EXPECT(Dart_IsString(ext32));
   EXPECT(!Dart_IsString8(ext32));
   EXPECT(!Dart_IsString16(ext32));
   EXPECT(Dart_IsExternalString(ext32));
 }
 
 
+TEST_CASE(NewString) {
+  const char* ascii = "string";
+  Dart_Handle ascii_str = Dart_NewString(ascii);
+  EXPECT_VALID(ascii_str);
+  EXPECT(Dart_IsString(ascii_str));
+
+  const char* null = NULL;
+  Dart_Handle null_str = Dart_NewString(null);
+  EXPECT(Dart_IsError(null_str));
+
+  const char* utf8 = "\xE4\xBA\x8C";  // U+4E8C
+  Dart_Handle utf8_str = Dart_NewString(utf8);
+  EXPECT_VALID(utf8_str);
+  EXPECT(Dart_IsString(utf8_str));
+
+  const char* invalid = "\xE4\xBA";  // underflow
+  Dart_Handle invalid_str = Dart_NewString(invalid);
+  EXPECT(Dart_IsError(invalid_str));
+}
+
+
 TEST_CASE(ExternalStringGetPeer) {
   Dart_Handle result;
 
   uint8_t data8[] = { 'o', 'n', 'e', 0xFF };
   int peer_data = 123;
   void* peer = NULL;
 
   // Success.
   Dart_Handle ext8 = Dart_NewExternalString8(data8, ARRAY_SIZE(data8),
                                              &peer_data, NULL);
@@ skipping 4877 matching lines @@
   EXPECT_VALID(result);
   EXPECT(Dart_IsInteger(result));
   int64_t value = 0;
   EXPECT_VALID(Dart_IntegerToInt64(result, &value));
   EXPECT_EQ(0, value);
 }
 
 #endif  // defined(TARGET_ARCH_IA32) || defined(TARGET_ARCH_X64).
 
 }  // namespace dart