Issue 10584035: Merge 120636 - Fix framebuffer-object-attachment.html failures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10584035: Merge 120636 - Fix framebuffer-object-attachment.html failures (Closed)

Created:
8 years, 6 months ago by Zhenyao Mo

Modified:
8 years, 6 months ago

Reviewers:
zmo

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1180/

Visibility:
Public.

More Reviews

Description

Merge 120636 - Fix framebuffer-object-attachment.html failures https://bugs.webkit.org/show_bug.cgi?id=89387 Reviewed by Kenneth Russell. * html/canvas/WebGLFramebuffer.cpp: fix detachment behavior with depth/stencil/depth_stencil conflicts (WebCore::WebGLFramebuffer::setAttachmentForBoundFramebuffer): (WebCore::WebGLFramebuffer::removeAttachmentFromBoundFramebuffer): * html/canvas/WebGLFramebuffer.h: (WebGLFramebuffer): * html/canvas/WebGLRenderingContext.cpp: (WebCore): (WebCore::WebGLRenderingContext::framebufferRenderbuffer): move logic to WebGLFramebuffer (WebCore::WebGLRenderingContext::framebufferTexture2D): Ditto. (WebCore::WebGLRenderingContext::getParameter): Correct the wrong assumption that it's always checking the drawingbuffer's DEPTH_BITS/STENCIL_BITS * html/canvas/WebGLRenderingContext.h: (WebGLRenderingContext): TBR=zmo@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120840

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -50 lines)			Patch
M	Source/WebCore/html/canvas/WebGLFramebuffer.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/WebCore/html/canvas/WebGLFramebuffer.cpp	View	4 chunks	+15 lines, -4 lines	0 comments	Download
M	Source/WebCore/html/canvas/WebGLRenderingContext.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	Source/WebCore/html/canvas/WebGLRenderingContext.cpp	View	4 chunks	+2 lines, -40 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages