Fix Pylint presubmit check.

Fix Pylint presubmit check.

First, the environment variable for the child process was created but not
specified to subprocess.call().

Second, third_party/logilab/__init__.py tried to initialize itself with
pkg_resources.

TBR=chrisha@chromium.org
BUG=
TEST=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143111

[commit-bot: I haz the power, 2012-06-20 00:50:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/10582031/1

[commit-bot: I haz the power, 2012-06-20 00:52:41]

Presubmit check for 10582031-1 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...

** Presubmit Messages **
--tbr was specified, skipping OWNERS check

** Presubmit ERRORS **
tests/gclient_scm_test.py failed!
Command tests/gclient_scm_test.py returned non-zero exit status 1 in
/b/commit-queue/workdir/tools/depot_tools
.FEFEFEF...FE.FFERROR:root:Error during fast-forward merge in .!
.F............................
======================================================================
ERROR: testRevertMissing (__main__.ManagedGitWrapperTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_scm_test.py", line 770, in tearDown
    StdoutCheck.tearDown(self)
  File "/b/commit-queue/workdir/tools/depot_tools/testing_support/super_mox.py",
line 101, in tearDown
    self.assertEquals('', sys.stdout.getvalue())
AssertionError: '' != "\n_____ . at refs/heads/master\nUpdating
069c602..a7142dc\nFast-forward\n a |    1 +\n b |    1 +\n 2 files changed, 2
insertions(+)\n\n\n________ running 'git reset --hard origin/master' in
'/tmp/tmpNG0P35/.'\nHEAD is now at a7142dc Personalized\n\n________ running 'git
diff a7142dc9f0009350b96a11f372b6ea658592aa95' in '/tmp/tmpNG0P35/.'\n"

======================================================================
ERROR: testRevertModified (__main__.ManagedGitWrapperTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_scm_test.py", line 770, in tearDown
    StdoutCheck.tearDown(self)
  File "/b/commit-queue/workdir/tools/depot_tools/testing_support/super_mox.py",
line 101, in tearDown
    self.assertEquals('', sys.stdout.getvalue())
AssertionError: '' != "\n_____ . at refs/heads/master\nUpdating
069c602..a7142dc\nFast-forward\n a |    1 +\n b |    1 +\n 2 files changed, 2
insertions(+)\n\n\n________ running 'git reset --hard origin/master' in
'/tmp/tmpUqrh7h/.'\nHEAD is now at a7142dc Personalized\n\n________ running 'git
diff a7142dc9f0009350b96a11f372b6ea658592aa95' in '/tmp/tmpUqrh7h/.'\n"

======================================================================
ERROR: testRevertNew (__main__.ManagedGitWrapperTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_scm_test.py", line 770, in tearDown
    StdoutCheck.tearDown(self)
  File "/b/commit-queue/workdir/tools/depot_tools/testing_support/super_mox.py",
line 101, in tearDown
    self.assertEquals('', sys.stdout.getvalue())
AssertionError: '' != "\n_____ . at refs/heads/master\nUpdating
069c602..a7142dc\nFast-forward\n a |    1 +\n b |    1 +\n 2 files changed, 2
insertions(+)\n\n\n________ running 'git reset --hard origin/master' in
'/tmp/tmpbgA6VY/.'\nHEAD is now at a7142dc Personalized\n\n________ running 'git
diff a7142dc9f0009350b96a11f372b6ea658592aa95' in '/tmp/tmpbgA6VY/.'\n"

======================================================================
ERROR: testUpdateConflict (__main__.ManagedGitWrapperTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_scm_test.py", line 770, in tearDown
    StdoutCheck.tearDown(self)
  File "/b/commit-queue/workdir/tools/depot_tools/testing_support/super_mox.py",
line 101, in tearDown
    self.assertEquals('', sys.stdout.getvalue())
AssertionError: '' != "\n________ running 'git commit -am test' in
'/tmp/tmp1OHr7B/.'\n[new 6a141de] test\n 1 file changed, 1 insertion(+), 1
deletion(-)\n\n_____ . at refs/heads/master\nAttempting rebase onto
refs/remotes/origin/master...\n"

======================================================================
FAIL: testRevertMissing (__main__.ManagedGitWrapperTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_scm_test.py", line 822, in testRevertMissing
    self.assertTrue(sys.stdout.getvalue().startswith(expectation))
AssertionError

======================================================================
FAIL: testRevertModified (__main__.ManagedGitWrapperTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_scm_test.py", line 869, in testRevertModified
    self.assertTrue(sys.stdout.getvalue().startswith(expectation))
AssertionError

======================================================================
FAIL: testRevertNew (__main__.ManagedGitWrapperTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_scm_test.py", line 899, in testRevertNew
    self.assertTrue(sys.stdout.getvalue().startswith(expectation))
AssertionError

======================================================================
FAIL: testRevertNone (__main__.ManagedGitWrapperTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_scm_test.py", line 844, in testRevertNone
    join(self.root_dir, '.'))
  File "/b/commit-queue/workdir/tools/depot_tools/testing_support/super_mox.py",
line 110, in checkstdout
    self.assertEquals(expected, value)
AssertionError: "\n_____ . at refs/heads/master\nUpdating
069c602..a7142dc\nFast-forward\n a |    1 +\n b |    1 +\n 2 files changed, 2
insertions(+), 0 deletions(-)\n\n\n________ running 'git reset --hard
origin/master' in '/tmp/tmpAIARhs/.'\nHEAD is now at a7142dc Personalized\n" !=
"\n_____ . at refs/heads/master\nUpdating 069c602..a7142dc\nFast-forward\n a |  
 1 +\n b |    1 +\n 2 files changed, 2 insertions(+)\n\n\n________ running 'git
reset --hard origin/master' in '/tmp/tmpAIARhs/.'\nHEAD is now at a7142dc
Personalized\n"

======================================================================
FAIL: testUpdateConflict (__main__.ManagedGitWrapperTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_scm_test.py", line 1056, in testUpdateConflict
    self.assertTrue(sys.stdout.getvalue().endswith(end))
AssertionError

======================================================================
FAIL: testUpdateReset (__main__.ManagedGitWrapperTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_scm_test.py", line 980, in testUpdateReset
    % join(self.root_dir, '.'))
  File "/b/commit-queue/workdir/tools/depot_tools/testing_support/super_mox.py",
line 110, in checkstdout
    self.assertEquals(expected, value)
AssertionError: "\n________ running 'git reset --hard HEAD' in
'/tmp/tmpShozAP/.'\nHEAD is now at 069c602 A and B\n\n_____ . at
refs/heads/master\nUpdating 069c602..a7142dc\nFast-forward\n a |    1 +\n b |   
1 +\n 2 files changed, 2 insertions(+), 0 deletions(-)\n\n" != "\n________
running 'git reset --hard HEAD' in '/tmp/tmpShozAP/.'\nHEAD is now at 069c602 A
and B\n\n_____ . at refs/heads/master\nUpdating 069c602..a7142dc\nFast-forward\n
a |    1 +\n b |    1 +\n 2 files changed, 2 insertions(+)\n\n"

======================================================================
FAIL: testUpdateResetDeleteUnversionedTrees (__main__.ManagedGitWrapperTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_scm_test.py", line 1009, in
testUpdateResetDeleteUnversionedTrees
    '.'))
  File "/b/commit-queue/workdir/tools/depot_tools/testing_support/super_mox.py",
line 110, in checkstdout
    self.assertEquals(expected, value)
AssertionError: "\n________ running 'git reset --hard HEAD' in
'/tmp/tmpYtzcAB/.'\nHEAD is now at 069c602 A and B\n\n_____ . at
refs/heads/master\nUpdating 069c602..a7142dc\nFast-forward\n a |    1 +\n b |   
1 +\n 2 files changed, 2 insertions(+), 0 deletions(-)\n\n\n_____ removing
unversioned directory dir/\n" != "\n________ running 'git reset --hard HEAD' in
'/tmp/tmpYtzcAB/.'\nHEAD is now at 069c602 A and B\n\n_____ . at
refs/heads/master\nUpdating 069c602..a7142dc\nFast-forward\n a |    1 +\n b |   
1 +\n 2 files changed, 2 insertions(+)\n\n\n_____ removing unversioned directory
dir/\n"

======================================================================
FAIL: testUpdateUpdate (__main__.ManagedGitWrapperTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_scm_test.py", line 951, in testUpdateUpdate
    '\n_____ . at refs/heads/master\n'
  File "/b/commit-queue/workdir/tools/depot_tools/testing_support/super_mox.py",
line 110, in checkstdout
    self.assertEquals(expected, value)
AssertionError: '\n_____ . at refs/heads/master\nUpdating
069c602..a7142dc\nFast-forward\n a |    1 +\n b |    1 +\n 2 files changed, 2
insertions(+), 0 deletions(-)\n\n' != '\n_____ . at refs/heads/master\nUpdating
069c602..a7142dc\nFast-forward\n a |    1 +\n b |    1 +\n 2 files changed, 2
insertions(+)\n\n'

----------------------------------------------------------------------
Ran 42 tests in 1.647s

FAILED (failures=8, errors=4)


Failed to checkout rietveld. Do you have mercurial installed?
[Errno 2] No such file or directory

Presubmit checks took 130.7s to calculate.

[chrisha, 2012-06-20 13:20:32]

I'm unable to review this as the patch appears to be empty (Rietveld just gives
me an error when trying to look at the diffs). Upload again?

[Peter Mayo, 2012-06-20 13:55:39]

On 2012/06/20 13:20:32, chrisha wrote:
> I'm unable to review this as the patch appears to be empty (Rietveld just
gives
> me an error when trying to look at the diffs). Upload again?

ditto here.

Being committed though, viewvc shows the diffs just fine.

I don't completely understand all the ramifications of deleting __init__.py, but
otherwise Looks Good.

[chrisha, 2012-06-20 14:04:52]

I looked through the diff on viewvc, and it looks fine to me. But, ditto on
Peter's comment regarding the pkg_resources. It appears that it's only necessary
so that individually packaged eggs can have overlapping namespaces? (Which is
not an issue for us because the packages have been unzipped and dumped in a
directory hierarchy together?)

Otherwise, lgtm.

[M-A Ruel, 2012-06-20 14:28:23]

On 2012/06/20 14:04:52, chrisha wrote:
> I looked through the diff on viewvc, and it looks fine to me. But, ditto on
> Peter's comment regarding the pkg_resources. It appears that it's only
necessary
> so that individually packaged eggs can have overlapping namespaces? (Which is
> not an issue for us because the packages have been unzipped and dumped in a
> directory hierarchy together?)
> 
> Otherwise, lgtm.

FTR, you can see the diff with the "Download raw patch set" link;
https://chromiumcodereview.appspot.com/download/issue10582031_1.diff

The problem happens to whoever has pylint installed. The declare_namespace()
call caused the version in
/usr/local/lib/python2.7/dist-packages/pylint-0.25.1-py2.7.egg/pylint/ to be
instantiated, causing conflicts with the one in third_party.