presubmit_canned_checks.py - Issue 10582031: Fix Pylint presubmit check.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: presubmit_canned_checks.py

Issue 10582031: Fix Pylint presubmit check. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: presubmit_canned_checks.py

diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py

index a5f17dad564db038fa21ac99a8153b65b135fbe5..1558ac3222804570198ab6dcdd1fd1662f5fe63f 100644

--- a/presubmit_canned_checks.py

+++ b/presubmit_canned_checks.py

@@ -657,7 +657,7 @@ def RunPylint(input_api, output_api, white_list=None, black_list=None,

command = [input_api.python_executable,

input_api.os_path.join(_HERE, 'third_party', 'pylint.py')]

try:

- return input_api.subprocess.call(command + files + extra_args)

+ return input_api.subprocess.call(command + files + extra_args, env=env)

except OSError:

return 'Pylint failed!'

« no previous file with comments | « no previous file | tests/presubmit_unittest.py » ('j') | no next file with comments »