Issue 10582009: mac: Remove star.pdf in favor of star.png

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10582009: mac: Remove star.pdf in favor of star.png (Closed)

Created:
8 years, 6 months ago by Nico

Modified:
8 years, 6 months ago

Reviewers:
Robert Sesek

CC:
chromium-reviews, James Su, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

mac: Remove star.pdf in favor of star.png BUG=111101 TEST=omnibox star icon looks slightly different Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=142877

Patch Set 2 : . #

Total comments: 1

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -672 lines)			Patch
D	chrome/app/theme/star.pdf	View	1	1 chunk	+0 lines, -387 lines	0 comments	Download
D	chrome/app/theme/star_lit.pdf	View	1	1 chunk	+0 lines, -278 lines	0 comments	Download
M	chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm	View		1 chunk	+0 lines, -5 lines	1 comment	Download
M	chrome/chrome_dll.gypi	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nico

https://chromiumcodereview.appspot.com/10582009/diff/2001/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm File chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm (right): https://chromiumcodereview.appspot.com/10582009/diff/2001/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm#newcode165 chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm:165: return rb.GetNativeImageNamed(resource_id); The fall-through down here ends up loading ...

8 years, 6 months ago (2012-06-18 22:46:50 UTC) #1

Nico

Argh, I failed to put your name in the "reviewer" field on this one

8 years, 6 months ago (2012-06-19 00:36:28 UTC) #2

LGTM

Expand Messages | Collapse Messages

Issue 10582009: mac: Remove star.pdf in favor of star.png (Closed)

Description

Patch Set 1 #

Patch Set 2 : . #

Messages