mac: Remove star.pdf in favor of star.png

chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h"
 
 #include <Carbon/Carbon.h>  // kVK_Return
 
 #include "base/property_bag.h"
 #include "base/string_util.h"
@@ skipping 117 matching lines @@
                      static_cast<NSInteger>(component.len));
 }
 
 }  // namespace
 
 // static
 NSImage* OmniboxViewMac::ImageForResource(int resource_id) {
   NSString* image_name = nil;
 
   switch(resource_id) {
-    // From the autocomplete popup, or the star icon at the RHS of the
-    // text field.
-    case IDR_STAR: image_name = @"star.pdf"; break;
-    case IDR_STAR_LIT: image_name = @"star_lit.pdf"; break;
-
     // Values from |AutocompleteMatch::TypeToIcon()|.
     case IDR_OMNIBOX_SEARCH:
       image_name = @"omnibox_search.pdf"; break;
     case IDR_OMNIBOX_HTTP:
       image_name = @"omnibox_http.pdf"; break;
     case IDR_OMNIBOX_EXTENSION_APP:
       image_name = @"omnibox_extension_app.pdf"; break;
 
     // Values from |ToolbarModel::GetIcon()|.
     case IDR_OMNIBOX_HTTPS_VALID:
       image_name = @"omnibox_https_valid.pdf"; break;
     case IDR_OMNIBOX_HTTPS_WARNING:
       image_name = @"omnibox_https_warning.pdf"; break;
     case IDR_OMNIBOX_HTTPS_INVALID:
       image_name = @"omnibox_https_invalid.pdf"; break;
   }
 
   if (image_name) {
     if (NSImage* image = gfx::GetCachedImageWithName(image_name)) {
       return image;
     } else {
       NOTREACHED()
           << "Missing image for " << base::SysNSStringToUTF8(image_name);
     }
   }
 
   ResourceBundle& rb = ResourceBundle::GetSharedInstance();
   return rb.GetNativeImageNamed(resource_id);

[Nico, 2012/06/18 22:46:50]

The fall-through down here ends up loading the image resource instead, which has
a 2x bitmap.

 }
 
 OmniboxViewMac::OmniboxViewMac(AutocompleteEditController* controller,
                                ToolbarModel* toolbar_model,
                                Profile* profile,
                                CommandUpdater* command_updater,
                                AutocompleteTextField* field)
     : model_(new AutocompleteEditModel(this, controller, profile)),
       popup_view_(new OmniboxPopupViewMac(this, model_.get(), profile, field)),
       controller_(controller),
@@ skipping 940 matching lines @@
 
 void OmniboxViewMac::PlaceCaretAt(NSUInteger pos) {
   DCHECK(pos <= GetTextLength());
   SetSelectedRange(NSMakeRange(pos, pos));
 }
 
 bool OmniboxViewMac::IsCaretAtEnd() const {
   const NSRange selection = GetSelectedRange();
   return selection.length == 0 && selection.location == GetTextLength();
 }