Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 10581043: Merge 142921 - Use an infobar instead of alert box for extension install (Closed)

Created:
8 years, 6 months ago by Aaron Boodman
Modified:
8 years, 6 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, rdsmith+dwatch_chromium.org
Visibility:
Public.

Description

Merge 142921 - Use an infobar instead of alert box for extension install error. Also, setup the 'learn more' link for off-store install failure, but don't enable yet as we don't quite have anything to link to. BUG=55584 TBR=yoz@chromium.org Review URL: https://chromiumcodereview.appspot.com/10559056 TBR=aa@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143213

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -67 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/crx_installer.h View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 14 chunks +56 lines, -49 lines 0 comments Download
M chrome/browser/extensions/crx_installer_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/extensions/crx_installer_error.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/extensions/extension_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_install_prompt.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_install_prompt.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_install_ui.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_install_ui_android.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_install_ui_android.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_install_ui_default.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_install_ui_default.cc View 3 chunks +51 lines, -4 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Aaron Boodman
8 years, 6 months ago (2012-06-20 18:41:24 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698