Issue 10559056: Use an infobar instead of alert box for extension install error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10559056: Use an infobar instead of alert box for extension install error. (Closed)

Created:
8 years, 6 months ago by Aaron Boodman

Modified:
8 years, 6 months ago

Reviewers:

CC:
chromium-reviews, Avi (use Gerrit), mihaip-chromium-reviews_chromium.org, creis+watch_chromium.org, jochen+watch-content_chromium.org, brettw-cc_chromium.org, jam, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, ajwong+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use an infobar instead of alert box for extension install error. Also, setup the 'learn more' link for off-store install failure, but don't enable yet as we don't quite have anything to link to. BUG=55584 TBR=yoz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=142921

Patch Set 1 #

Patch Set 2 : cleanup #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+163 lines, -63 lines)			Patch
M	chrome/app/generated_resources.grd	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/crx_installer.h	View		3 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/crx_installer.cc	View		14 chunks	+56 lines, -49 lines	0 comments	Download
A	chrome/browser/extensions/crx_installer_error.h	View	1	1 chunk	+41 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_install_prompt.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_install_prompt.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_install_ui.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_install_ui_android.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_install_ui_android.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_install_ui_default.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_install_ui_default.cc	View	1	3 chunks	+51 lines, -4 lines	0 comments	Download
M	chrome/chrome_browser_extensions.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download