Issue 10581029: Make GL_CHROMIUM_consistent_uniform_locations slighty more robust

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10581029: Make GL_CHROMIUM_consistent_uniform_locations slighty more robust (Closed)

Created:
8 years, 6 months ago by greggman

Modified:
8 years, 6 months ago

Reviewers:
apatrick_chromium

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, apatrick_chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make GL_CHROMIUM_consistent_uniform_locations slighty more robust Added a program argument so that at least in debug we can verify locations are correct. It also means we could fallback to actually calling GetUniformLocation if need be. TEST=unit tests BUG=132844 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=143126

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+132 lines, -25 lines)			Patch
M	gpu/GLES2/extensions/CHROMIUM/CHROMIUM_consistent_uniform_locations.txt	View		3 chunks	+9 lines, -7 lines	0 comments	Download
M	gpu/command_buffer/client/gles2_c_lib_autogen.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	gpu/command_buffer/client/gles2_implementation.cc	View		2 chunks	+20 lines, -1 line	0 comments	Download
M	gpu/command_buffer/client/gles2_implementation_autogen.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/command_buffer/client/gles2_implementation_unittest.cc	View	1	6 chunks	+80 lines, -5 lines	0 comments	Download
M	gpu/command_buffer/client/program_info_manager.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	gpu/command_buffer/client/share_group.h	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/client/share_group.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/cmd_buffer_functions.txt	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	gpu/command_buffer/tests/gl_consistent_uniform_locations_unittest.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	third_party/khronos/GLES2/gl2ext.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	third_party/khronos/README.chromium	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/10581029/9001

8 years, 6 months ago (2012-06-20 01:17:44 UTC) #3

Change committed as 143126

Expand Messages | Collapse Messages