Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: gpu/GLES2/extensions/CHROMIUM/CHROMIUM_consistent_uniform_locations.txt

Issue 10581029: Make GL_CHROMIUM_consistent_uniform_locations slighty more robust (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gpu/command_buffer/client/gles2_c_lib_autogen.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/GLES2/extensions/CHROMIUM/CHROMIUM_consistent_uniform_locations.txt
diff --git a/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_consistent_uniform_locations.txt b/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_consistent_uniform_locations.txt
index 8a7d163ef0f71bb8137439158037f1f1f23d976a..e7e8907d4d5e20f93ac4021a87039616b56f96cd 100644
--- a/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_consistent_uniform_locations.txt
+++ b/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_consistent_uniform_locations.txt
@@ -19,14 +19,13 @@ Overview
This extension guarantees uniforms always have the same locations.
This allows the client program to know the locations of uniforms
- without having to compile the shaders, link the program and query
- the locations and therefore have no blocking calls when initializing
- programs.
+ without having to wait for shaders to compile or GLSL programs to
+ link to query the locations and therefore have no blocking calls
+ when initializing programs.
To be forward compatible the locations are provided through the
- function GetUniformLocationsCHROMIUM but they can be provided
- even before linking a program and therefore do not have to wait
- for compile or link completion to return results.
+ function GetUniformLocationsCHROMIUM. LinkProgram must be called
+ before calling GetUniformLocationsCHROMIUM.
Issues
@@ -40,7 +39,8 @@ New Tokens
New Procedures and Functions
- void GetUniformLocationsCHROMIUM (const GLUniformDefinitionCHROMIUM* uniforms,
+ void GetUniformLocationsCHROMIUM (GLuint program,
+ const GLUniformDefinitionCHROMIUM* uniforms,
GLsizei count, GLsizei max_locations,
GLint* locations);
@@ -84,3 +84,5 @@ New State
Revision History
7/17/2012 Documented the extension
+ 7/19/2012 Added <program> argument.
+
« no previous file with comments | « no previous file | gpu/command_buffer/client/gles2_c_lib_autogen.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698