Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: runtime/vm/object_test.cc

Issue 10581006: Replace class with class ids inside ICData (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "platform/assert.h" 5 #include "platform/assert.h"
6 #include "vm/assembler.h" 6 #include "vm/assembler.h"
7 #include "vm/bigint_operations.h" 7 #include "vm/bigint_operations.h"
8 #include "vm/isolate.h" 8 #include "vm/isolate.h"
9 #include "vm/object.h" 9 #include "vm/object.h"
10 #include "vm/object_store.h" 10 #include "vm/object_store.h"
(...skipping 2573 matching lines...) Expand 10 before | Expand all | Expand 10 after
2584 const String& target_name = String::Handle(String::New("Thun")); 2584 const String& target_name = String::Handle(String::New("Thun"));
2585 ICData& o1 = ICData::Handle(); 2585 ICData& o1 = ICData::Handle();
2586 o1 = ICData::New(function, target_name, id, num_args_tested); 2586 o1 = ICData::New(function, target_name, id, num_args_tested);
2587 EXPECT_EQ(1, o1.num_args_tested()); 2587 EXPECT_EQ(1, o1.num_args_tested());
2588 EXPECT_EQ(id, o1.id()); 2588 EXPECT_EQ(id, o1.id());
2589 EXPECT_EQ(function.raw(), o1.function()); 2589 EXPECT_EQ(function.raw(), o1.function());
2590 EXPECT_EQ(0, o1.NumberOfChecks()); 2590 EXPECT_EQ(0, o1.NumberOfChecks());
2591 EXPECT_EQ(target_name.raw(), o1.target_name()); 2591 EXPECT_EQ(target_name.raw(), o1.target_name());
2592 2592
2593 const Function& target1 = Function::Handle(GetDummyTarget("Thun")); 2593 const Function& target1 = Function::Handle(GetDummyTarget("Thun"));
2594 GrowableArray<const Class*> classes; 2594 GrowableArray<intptr_t> classes;
2595 ObjectStore* object_store = Isolate::Current()->object_store(); 2595 classes.Add(kSmi);
2596 const Class& smi_class = Class::ZoneHandle(object_store->smi_class());
2597 classes.Add(&smi_class);
2598 o1.AddCheck(classes, target1); 2596 o1.AddCheck(classes, target1);
2599 EXPECT_EQ(1, o1.NumberOfChecks()); 2597 EXPECT_EQ(1, o1.NumberOfChecks());
2600 Class& test_class = Class::Handle(); 2598 intptr_t test_class_id = -1;
2601 Function& test_target = Function::Handle(); 2599 Function& test_target = Function::Handle();
2602 o1.GetOneClassCheckAt(0, &test_class, &test_target); 2600 o1.GetOneClassCheckAt(0, &test_class_id, &test_target);
2603 EXPECT_EQ(smi_class.raw(), test_class.raw()); 2601 EXPECT_EQ(kSmi, test_class_id);
2604 EXPECT_EQ(target1.raw(), test_target.raw()); 2602 EXPECT_EQ(target1.raw(), test_target.raw());
2605 GrowableArray<const Class*> test_classes; 2603 GrowableArray<intptr_t> test_class_ids;
2606 o1.GetCheckAt(0, &test_classes, &test_target); 2604 o1.GetCheckAt(0, &test_class_ids, &test_target);
2607 EXPECT_EQ(1, test_classes.length()); 2605 EXPECT_EQ(1, test_class_ids.length());
2608 EXPECT_EQ(smi_class.raw(), test_classes[0]->raw()); 2606 EXPECT_EQ(kSmi, test_class_ids[0]);
2609 EXPECT_EQ(target1.raw(), test_target.raw()); 2607 EXPECT_EQ(target1.raw(), test_target.raw());
2610 2608
2611 classes.Clear(); 2609 classes.Clear();
2612 const Function& target2 = Function::Handle(GetDummyTarget("Thun")); 2610 const Function& target2 = Function::Handle(GetDummyTarget("Thun"));
2613 const Class& double_class = Class::ZoneHandle(object_store->double_class()); 2611 classes.Add(kDouble);
2614 classes.Add(&double_class);
2615 o1.AddCheck(classes, target2); 2612 o1.AddCheck(classes, target2);
2616 EXPECT_EQ(2, o1.NumberOfChecks()); 2613 EXPECT_EQ(2, o1.NumberOfChecks());
2617 o1.GetOneClassCheckAt(1, &test_class, &test_target); 2614 o1.GetOneClassCheckAt(1, &test_class_id, &test_target);
2618 EXPECT_EQ(double_class.raw(), test_class.raw()); 2615 EXPECT_EQ(kDouble, test_class_id);
2619 EXPECT_EQ(target2.raw(), test_target.raw()); 2616 EXPECT_EQ(target2.raw(), test_target.raw());
2620 2617
2621 ICData& o2 = ICData::Handle(); 2618 ICData& o2 = ICData::Handle();
2622 o2 = ICData::New(function, target_name, 57, 2); 2619 o2 = ICData::New(function, target_name, 57, 2);
2623 EXPECT_EQ(2, o2.num_args_tested()); 2620 EXPECT_EQ(2, o2.num_args_tested());
2624 EXPECT_EQ(57, o2.id()); 2621 EXPECT_EQ(57, o2.id());
2625 EXPECT_EQ(function.raw(), o2.function()); 2622 EXPECT_EQ(function.raw(), o2.function());
2626 EXPECT_EQ(0, o2.NumberOfChecks()); 2623 EXPECT_EQ(0, o2.NumberOfChecks());
2627 classes.Clear(); 2624 classes.Clear();
2628 classes.Add(&smi_class); 2625 classes.Add(kSmi);
2629 classes.Add(&smi_class); 2626 classes.Add(kSmi);
2630 o2.AddCheck(classes, target1); 2627 o2.AddCheck(classes, target1);
2631 EXPECT_EQ(1, o2.NumberOfChecks()); 2628 EXPECT_EQ(1, o2.NumberOfChecks());
2632 o2.GetCheckAt(0, &test_classes, &test_target); 2629 o2.GetCheckAt(0, &test_class_ids, &test_target);
2633 EXPECT_EQ(2, test_classes.length()); 2630 EXPECT_EQ(2, test_class_ids.length());
2634 EXPECT_EQ(smi_class.raw(), test_classes[0]->raw()); 2631 EXPECT_EQ(kSmi, test_class_ids[0]);
2635 EXPECT_EQ(smi_class.raw(), test_classes[1]->raw()); 2632 EXPECT_EQ(kSmi, test_class_ids[1]);
2636 EXPECT_EQ(target1.raw(), test_target.raw()); 2633 EXPECT_EQ(target1.raw(), test_target.raw());
2637 } 2634 }
2638 2635
2639 2636
2640 TEST_CASE(SubtypeTestCache) { 2637 TEST_CASE(SubtypeTestCache) {
2641 String& class_name = String::Handle(String::NewSymbol("EmptyClass")); 2638 String& class_name = String::Handle(String::NewSymbol("EmptyClass"));
2642 Script& script = Script::Handle(); 2639 Script& script = Script::Handle();
2643 const Class& empty_class = 2640 const Class& empty_class =
2644 Class::Handle(Class::New(class_name, script, Scanner::kDummyTokenIndex)); 2641 Class::Handle(Class::New(class_name, script, Scanner::kDummyTokenIndex));
2645 SubtypeTestCache& cache = SubtypeTestCache::Handle(SubtypeTestCache::New()); 2642 SubtypeTestCache& cache = SubtypeTestCache::Handle(SubtypeTestCache::New());
(...skipping 27 matching lines...) Expand all
2673 EXPECT(Field::IsSetterName(setter_f)); 2670 EXPECT(Field::IsSetterName(setter_f));
2674 EXPECT_STREQ(f.ToCString(), 2671 EXPECT_STREQ(f.ToCString(),
2675 String::Handle(Field::NameFromGetter(getter_f)).ToCString()); 2672 String::Handle(Field::NameFromGetter(getter_f)).ToCString());
2676 EXPECT_STREQ(f.ToCString(), 2673 EXPECT_STREQ(f.ToCString(),
2677 String::Handle(Field::NameFromSetter(setter_f)).ToCString()); 2674 String::Handle(Field::NameFromSetter(setter_f)).ToCString());
2678 } 2675 }
2679 2676
2680 #endif // defined(TARGET_ARCH_IA32) || defined(TARGET_ARCH_X64). 2677 #endif // defined(TARGET_ARCH_IA32) || defined(TARGET_ARCH_X64).
2681 2678
2682 } // namespace dart 2679 } // namespace dart
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698