Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(872)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10581006: Replace class with class ids inside ICData (Closed)

Created:
8 years, 6 months ago by srdjan
Modified:
8 years, 6 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Ivan Posva
Visibility:
Public.

Description

Replace class with class ids inside ICData. Do minimal changes in the old compiler. One of next CLs similar cleanup to SubtypeTestCache class.

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Total comments: 8

Patch Set 8 : #

Patch Set 9 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -172 lines) Patch
M runtime/vm/code_generator.cc View 1 2 3 4 5 6 7 2 chunks +10 lines, -8 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 1 2 3 4 5 6 7 11 chunks +29 lines, -30 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 2 3 4 5 6 7 4 chunks +6 lines, -6 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 2 3 4 5 6 7 4 chunks +6 lines, -6 lines 0 comments Download
M runtime/vm/object.h View 1 2 3 4 5 6 7 1 chunk +6 lines, -3 lines 0 comments Download
M runtime/vm/object.cc View 1 2 3 4 5 6 7 2 chunks +16 lines, -14 lines 0 comments Download
M runtime/vm/object_test.cc View 1 2 3 4 5 6 7 2 chunks +18 lines, -21 lines 0 comments Download
M runtime/vm/opt_code_generator_ia32.cc View 1 2 3 4 5 6 7 10 chunks +43 lines, -50 lines 0 comments Download
M runtime/vm/raw_object.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/stub_code_ia32.cc View 1 2 3 4 5 6 7 5 chunks +16 lines, -17 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 1 2 3 4 5 6 7 4 chunks +14 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
srdjan
8 years, 6 months ago (2012-06-19 02:01:49 UTC) #1
Vyacheslav Egorov (Google)
lgtm https://chromiumcodereview.appspot.com/10581006/diff/9/runtime/vm/opt_code_generator_ia32.cc File runtime/vm/opt_code_generator_ia32.cc (right): https://chromiumcodereview.appspot.com/10581006/diff/9/runtime/vm/opt_code_generator_ia32.cc#newcode1406 runtime/vm/opt_code_generator_ia32.cc:1406: intptr_t class_id = -1; kIllegalObjectKind instead of -1? ...
8 years, 6 months ago (2012-06-19 12:01:05 UTC) #2
srdjan
https://chromiumcodereview.appspot.com/10581006/diff/9/runtime/vm/opt_code_generator_ia32.cc File runtime/vm/opt_code_generator_ia32.cc (right): https://chromiumcodereview.appspot.com/10581006/diff/9/runtime/vm/opt_code_generator_ia32.cc#newcode1406 runtime/vm/opt_code_generator_ia32.cc:1406: intptr_t class_id = -1; On 2012/06/19 12:01:06, Vyacheslav Egorov ...
8 years, 6 months ago (2012-06-19 15:19:16 UTC) #3
srdjan
8 years, 6 months ago (2012-06-19 21:15:15 UTC) #4 
Submitted as https://chromiumcodereview.appspot.com/10580024/

On 2012/06/19 15:19:16, srdjan wrote:
>
https://chromiumcodereview.appspot.com/10581006/diff/9/runtime/vm/opt_code_ge...
> File runtime/vm/opt_code_generator_ia32.cc (right):
> 
>
https://chromiumcodereview.appspot.com/10581006/diff/9/runtime/vm/opt_code_ge...
> runtime/vm/opt_code_generator_ia32.cc:1406: intptr_t class_id = -1;
> On 2012/06/19 12:01:06, Vyacheslav Egorov (Google) wrote:
> > kIllegalObjectKind instead of -1?
> 
> Done.
> 
>
https://chromiumcodereview.appspot.com/10581006/diff/9/runtime/vm/stub_code_i...
> File runtime/vm/stub_code_ia32.cc (right):
> 
>
https://chromiumcodereview.appspot.com/10581006/diff/9/runtime/vm/stub_code_i...
> runtime/vm/stub_code_ia32.cc:1697: __ Bind(&get_class_id);
> On 2012/06/19 12:01:06, Vyacheslav Egorov (Google) wrote:
> > get_class_id_as_smi
> 
> Done.
> 
>
https://chromiumcodereview.appspot.com/10581006/diff/9/runtime/vm/stub_code_x...
> File runtime/vm/stub_code_x64.cc (right):
> 
>
https://chromiumcodereview.appspot.com/10581006/diff/9/runtime/vm/stub_code_x...
> runtime/vm/stub_code_x64.cc:1610: __ cmpq(RAX, R13);  // = Class id match?
> On 2012/06/19 12:01:06, Vyacheslav Egorov (Google) wrote:
> > remove =
> 
> Done.
> 
>
https://chromiumcodereview.appspot.com/10581006/diff/9/runtime/vm/stub_code_x...
> runtime/vm/stub_code_x64.cc:1672: __ Bind(&get_class_id);
> On 2012/06/19 12:01:06, Vyacheslav Egorov (Google) wrote:
> > get_class_id_as_smi
> 
> Done.

Powered by Google App Engine
This is Rietveld 408576698