Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Issue 10579022: Add a CONNECT_REQUESTED state to Network ConnectionState (Closed)

Created:
8 years, 6 months ago by stevenjb
Modified:
8 years, 6 months ago
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, achuith+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Add a CONNECT_REQUESTED state to Network ConnectionState. When a connection request is made, Chrome now sets the state to CONNECT_REQUESTED and ignores "Idle" state updates while in that state. This informs the UI to show "connecting" icons / text until the connection attempt succeeds or fails. Also: Don't update the network icon while scanning. Also: includes a bunch of logging changes for improved debugging. This alos fixes the mock expectations so that browser_tests should pass. Original CL: https://chromiumcodereview.appspot.com/10554013 BUG=125121 TEST=See issue, test connecting between networks, UI should behave correctly. For chrome/browser/chromeos/gdata: TBR=gspencer@chromium.org, tbarzic@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143072

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -81 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/cros/cros_mock.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/cros/cros_network_functions.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/cros/network_constants.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/cros/network_library.h View 3 chunks +16 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library.cc View 5 chunks +43 lines, -29 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library_impl_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/cros/network_library_impl_cros.cc View 7 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library_impl_stub.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/cros/network_parser.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_sync_client_unittest.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/status/network_menu_icon.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/status/network_menu_icon_unittest.cc View 10 chunks +21 lines, -16 lines 0 comments Download
M dbus/object_proxy.cc View 1 chunk +1 line, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698