Add a CONNECT_REQUESTED state to Network ConnectionState.

Add a CONNECT_REQUESTED state to Network ConnectionState.
When a connection request is made, Chrome now sets the state to CONNECT_REQUESTED and ignores "Idle" state updates while in that state.
This informs the UI to show "connecting" icons / text until the connection attempt succeeds or fails.
Also: Don't update the network icon while scanning.
Also: includes a bunch of logging changes for improved debugging.

BUG=125121
TEST=See issue, test connecting between networks, UI should behave correctly.
For chrome/browser/chromeos/gdata:
TBR=tbarzic@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=142847

[stevenjb, 2012-06-15 21:36:25]

hasimoto@: please look at the change to object_proxy.cc

[hashimoto, 2012-06-18 02:05:10]

http://codereview.chromium.org/10554013/diff/4001/dbus/object_proxy.cc
File dbus/object_proxy.cc (right):

http://codereview.chromium.org/10554013/diff/4001/dbus/object_proxy.cc#newcod...
dbus/object_proxy.cc:495: LOG(ERROR) << "Failed to call method: "
How about also printing service_name and ordering values like dbus_send(1)?
It'll be like the following.

  LOG(ERROR) << "Failed to call method: "
             << service_name_ << " " << object_path_.value() << " "
             << interface_name << "." << method_name
             << ": " << error_name << ": " << error_message;

[stevenjb, 2012-06-18 16:52:00]

On 2012/06/18 02:05:10, hashimoto wrote:
> http://codereview.chromium.org/10554013/diff/4001/dbus/object_proxy.cc
> File dbus/object_proxy.cc (right):
> 
>
http://codereview.chromium.org/10554013/diff/4001/dbus/object_proxy.cc#newcod...
> dbus/object_proxy.cc:495: LOG(ERROR) << "Failed to call method: "
> How about also printing service_name and ordering values like dbus_send(1)?
> It'll be like the following.
> 
>   LOG(ERROR) << "Failed to call method: "
>              << service_name_ << " " << object_path_.value() << " "
>              << interface_name << "." << method_name
>              << ": " << error_name << ": " << error_message;

Maybe in a follow-up? I just added object_path since it was very helpful for
tracking down the source of the log spam.

[Greg Spencer (Chromium), 2012-06-18 17:02:38]

http://codereview.chromium.org/10554013/diff/4001/chrome/browser/chromeos/cro...
File chrome/browser/chromeos/cros/network_constants.h (right):

http://codereview.chromium.org/10554013/diff/4001/chrome/browser/chromeos/cro...
chrome/browser/chromeos/cros/network_constants.h:230: STATE_CONNECT_REQUESTED  =
11,  // Chrome only state
Do you mean that this state doesn't exist in flimflam/shill?

http://codereview.chromium.org/10554013/diff/4001/chrome/browser/chromeos/cro...
File chrome/browser/chromeos/cros/network_library.h (right):

http://codereview.chromium.org/10554013/diff/4001/chrome/browser/chromeos/cro...
chrome/browser/chromeos/cros/network_library.h:533: void set_idle() {
Any reason this shouldn't be called "set_disconnected" to match SetDisconnected
above?  And I'm kind of curious why there isn't also a
"STATE_DISCONNECT_REQUESTED": is the switch to idle atomic?

[stevenjb (google-dont-use), 2012-06-18 17:35:31]

PTAL

http://codereview.chromium.org/10554013/diff/4001/chrome/browser/chromeos/cro...
File chrome/browser/chromeos/cros/network_constants.h (right):

http://codereview.chromium.org/10554013/diff/4001/chrome/browser/chromeos/cro...
chrome/browser/chromeos/cros/network_constants.h:230: STATE_CONNECT_REQUESTED  =
11,  // Chrome only state
On 2012/06/18 17:02:38, Greg Spencer (Chromium) wrote:
> Do you mean that this state doesn't exist in flimflam/shill?
Yes.

http://codereview.chromium.org/10554013/diff/4001/chrome/browser/chromeos/cro...
File chrome/browser/chromeos/cros/network_library.h (right):

http://codereview.chromium.org/10554013/diff/4001/chrome/browser/chromeos/cro...
chrome/browser/chromeos/cros/network_library.h:533: void set_idle() {
On 2012/06/18 17:02:38, Greg Spencer (Chromium) wrote:
> Any reason this shouldn't be called "set_disconnected" to match
SetDisconnected
> above?  And I'm kind of curious why there isn't also a
> "STATE_DISCONNECT_REQUESTED": is the switch to idle atomic?
Done.
The UI doesn't currently care about a "disconnecting" state.  In practice, the
time between requested a disconnect and flimflam/shill switching to that state
is very small.

[Greg Spencer (Chromium), 2012-06-18 17:59:13]

lgtm

[hashimoto, 2012-06-18 18:13:41]

On 2012/06/18 16:52:00, stevenjb (chromium) wrote:
> On 2012/06/18 02:05:10, hashimoto wrote:
> > http://codereview.chromium.org/10554013/diff/4001/dbus/object_proxy.cc
> > File dbus/object_proxy.cc (right):
> > 
> >
>
http://codereview.chromium.org/10554013/diff/4001/dbus/object_proxy.cc#newcod...
> > dbus/object_proxy.cc:495: LOG(ERROR) << "Failed to call method: "
> > How about also printing service_name and ordering values like dbus_send(1)?
> > It'll be like the following.
> > 
> >   LOG(ERROR) << "Failed to call method: "
> >              << service_name_ << " " << object_path_.value() << " "
> >              << interface_name << "." << method_name
> >              << ": " << error_name << ": " << error_message;
> 
> Maybe in a follow-up? I just added object_path since it was very helpful for
> tracking down the source of the log spam.

ok, lgtm for object_proxy.cc