Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1108)

Unified Diff: content/browser/renderer_host/resource_handler.h

Issue 10578055: Rewrite guts of ResourceLoader and BufferedResourceHandler to suck less. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/resource_handler.h
===================================================================
--- content/browser/renderer_host/resource_handler.h (revision 144275)
+++ content/browser/renderer_host/resource_handler.h (working copy)
@@ -76,10 +76,8 @@
// out-params. This call will be followed by either OnReadCompleted or
// OnResponseCompleted, at which point the buffer may be recycled.
//
- // If this method returns false, then the request will not be read. This is
- // normally used in conjunction with ResourceDispatcherHost::PauseRequest to
- // pause the processing of the request. When the request is later resumed,
- // OnWillRead will be called again.
+ // If the handler returns false, then the request is cancelled. Otherwise,
+ // once data is available, OnReadCompleted will be called.
virtual bool OnWillRead(int request_id,
net::IOBuffer** buf,
int* buf_size,
@@ -90,7 +88,7 @@
// reading data. Set |*defer| to true to defer reading more response data.
// Call ResourceDispatcherHostImpl::ResumeDeferredRequest to continue reading
// response data.
- virtual bool OnReadCompleted(int request_id, int* bytes_read,
+ virtual bool OnReadCompleted(int request_id, int bytes_read,
bool* defer) = 0;
// The response is complete. The final response status is given. Returns
« no previous file with comments | « content/browser/renderer_host/resource_dispatcher_host_unittest.cc ('k') | content/browser/renderer_host/resource_loader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698