Rewrite guts of ResourceLoader and BufferedResourceHandler to suck less.

content/browser/renderer_host/resource_handler.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This is the browser side of the resource dispatcher, it receives requests
 // from the RenderProcessHosts, and dispatches them to URLRequests. It then
 // fowards the messages from the URLRequests back to the correct process for
 // handling.
 //
 // See http://dev.chromium.org/developers/design-documents/multi-process-resource-loading
@@ skipping 58 matching lines @@
   // delay the request from starting by setting |*defer = true|.  A deferred
   // request will not have called net::URLRequest::Start(), and will not resume
   // until someone calls ResourceDispatcherHost::StartDeferredRequest().
   virtual bool OnWillStart(int request_id, const GURL& url, bool* defer) = 0;
 
   // Data will be read for the response.  Upon success, this method places the
   // size and address of the buffer where the data is to be written in its
   // out-params.  This call will be followed by either OnReadCompleted or
   // OnResponseCompleted, at which point the buffer may be recycled.
   //
-  // If this method returns false, then the request will not be read.  This is
-  // normally used in conjunction with ResourceDispatcherHost::PauseRequest to
-  // pause the processing of the request.  When the request is later resumed,
-  // OnWillRead will be called again.
+  // If the handler returns false, then the request is cancelled.  Otherwise,
+  // once data is available, OnReadCompleted will be called.
   virtual bool OnWillRead(int request_id,
                           net::IOBuffer** buf,
                           int* buf_size,
                           int min_size) = 0;
 
   // Data (*bytes_read bytes) was written into the buffer provided by
   // OnWillRead.  A return value of false cancels the request, true continues
   // reading data.  Set |*defer| to true to defer reading more response data.
   // Call ResourceDispatcherHostImpl::ResumeDeferredRequest to continue reading
   // response data.
-  virtual bool OnReadCompleted(int request_id, int* bytes_read,
+  virtual bool OnReadCompleted(int request_id, int bytes_read,
                                bool* defer) = 0;
 
   // The response is complete.  The final response status is given.  Returns
   // false if the handler is deferring the call to a later time.  Otherwise,
   // the request will be destroyed upon return.
   virtual bool OnResponseCompleted(int request_id,
                                    const net::URLRequestStatus& status,
                                    const std::string& security_info) = 0;
 
   // This notification is synthesized by the RedirectToFileResourceHandler
   // to indicate progress of 'download_to_file' requests. OnReadCompleted
   // calls are consumed by the RedirectToFileResourceHandler and replaced
   // with OnDataDownloaded calls.
   virtual void OnDataDownloaded(int request_id, int bytes_downloaded) {}
 
  protected:
   ResourceHandler() : controller_(NULL) {}
   ResourceController* controller() { return controller_; }
 
  private:
   ResourceController* controller_;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_RESOURCE_HANDLER_H_