Notify Windows Shell after making Chrome default interactively

Notify Windows Shell after making Chrome default interactively

Patch From Gabriel Charette <gab@chromium.org>; 
BUG=132991
TEST=Chrome Metro tile appears immediately after making Chrome default.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=142911

[gab, 2012-06-19 01:13:33]

PTAL.

I have yet to try it (I had to sync for another CL and am now facing a near
full-rebuild), but I'm convinced this will fix it (or otherwise something very
similar if there is something I didn't think of and will see when I try it...).

Cheers,
Gab

[gab, 2012-06-19 02:35:21]

On 2012/06/19 01:13:33, gab wrote:
> PTAL.
> 
> I have yet to try it (I had to sync for another CL and am now facing a near
> full-rebuild), but I'm convinced this will fix it (or otherwise something very
> similar if there is something I didn't think of and will see when I try
it...).

It works :)!

> 
> Cheers,
> Gab

[gideonwald1, 2012-06-19 02:46:55]

Woot! :)

On Mon, Jun 18, 2012 at 7:35 PM, <gab@chromium.org> wrote:

> On 2012/06/19 01:13:33, gab wrote:
>
>> PTAL.
>>
>
>  I have yet to try it (I had to sync for another CL and am now facing a
>> near
>> full-rebuild), but I'm convinced this will fix it (or otherwise something
>> very
>> similar if there is something I didn't think of and will see when I try
>>
> it...).
>
> It works :)!
>
>
>  Cheers,
>> Gab
>>
>
>
>
>
http://codereview.chromium.**org/10576009/<http://codereview.chromium.org/105...
>

[grt (UTC plus 2), 2012-06-19 03:36:24]

nice work, man!

https://chromiumcodereview.appspot.com/10576009/diff/1/chrome/installer/util/...
File chrome/installer/util/shell_util.cc (right):

https://chromiumcodereview.appspot.com/10576009/diff/1/chrome/installer/util/...
chrome/installer/util/shell_util.cc:1187: SHChangeNotify(SHCNE_ASSOCCHANGED,
SHCNF_IDLIST, NULL, NULL);
how about moving this into LaunchSelectDefaultProtocolHandlerDialog?  it should
be safe to do the notify after prompting for other protocols.  if the shell's
handling of http is buggy, maybe it is for others as well.  by the same token,
if we're actually supposed to do the notify after the Open With dialog goes
away, then we definitely want to do this for all protocols.

[gab, 2012-06-19 04:12:13]

Done

https://chromiumcodereview.appspot.com/10576009/diff/1/chrome/installer/util/...
File chrome/installer/util/shell_util.cc (right):

https://chromiumcodereview.appspot.com/10576009/diff/1/chrome/installer/util/...
chrome/installer/util/shell_util.cc:1187: SHChangeNotify(SHCNE_ASSOCCHANGED,
SHCNF_IDLIST, NULL, NULL);
On 2012/06/19 03:36:24, grt wrote:
> how about moving this into LaunchSelectDefaultProtocolHandlerDialog?  it
should
> be safe to do the notify after prompting for other protocols.  if the shell's
> handling of http is buggy, maybe it is for others as well.  by the same token,
> if we're actually supposed to do the notify after the Open With dialog goes
> away, then we definitely want to do this for all protocols.

Good call, Done.

[grt (UTC plus 2), 2012-06-19 04:54:54]

lgtm