Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4623)

Unified Diff: chrome/installer/util/shell_util.cc

Issue 10576009: Notify Windows Shell after making Chrome default interactively (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: avoid double SUCCEEDED() Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/shell_util.cc
diff --git a/chrome/installer/util/shell_util.cc b/chrome/installer/util/shell_util.cc
index 582ef07bde29f55ce79f8cd2ba5b907f64f1d17c..4a4872339d7bd6e00a0368acf77906d023012900 100644
--- a/chrome/installer/util/shell_util.cc
+++ b/chrome/installer/util/shell_util.cc
@@ -610,7 +610,10 @@ bool LaunchSelectDefaultProtocolHandlerDialog(const wchar_t* protocol) {
HRESULT hr = SHOpenWithDialog(NULL, &open_as_info);
DLOG_IF(WARNING, FAILED(hr)) << "Failed to set as default " << protocol
<< " handler; hr=0x" << std::hex << hr;
- return SUCCEEDED(hr);
+ if (FAILED(hr))
+ return false;
+ SHChangeNotify(SHCNE_ASSOCCHANGED, SHCNF_IDLIST, NULL, NULL);
+ return true;
}
// Launches the Windows 7 and Windows 8 application association dialog, which
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698