Simplify fullscreen exit bubble on mac; updating always creates one freshly.

Simplify fullscreen exit bubble on mac; updating always creates one freshly.

This also moved the logic for when NOT to display the bubble to a single
location, fixing 129456.

BUG=129456
TEST=Manually, see bug.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143397

[scheib, 2012-06-18 22:46:02]

(not sure who best is for this, koz or jeremya)

[koz (OOO until 15th September), 2012-06-19 01:00:50]

I think jeremya would be more suitable for this code, I'm not familiar with this
code.

[jeremya, 2012-06-20 15:45:23]

lgtm mario, but I am not in the OWNERS file :)

[jeremya, 2012-06-20 15:48:45]

[+thakis, who reviewed a bunch of this code when it was first written.]

[Nico, 2012-06-20 15:52:10]

http://codereview.chromium.org/10573003/diff/1/chrome/browser/ui/cocoa/fullsc...
File chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm (left):

http://codereview.chromium.org/10573003/diff/1/chrome/browser/ui/cocoa/fullsc...
chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm:95: [self
hideSoon];
Why is this no longer necessary? (This is the bubble fade out animation, right?)

[Robert Sesek, 2012-06-20 15:58:57]

+rohitrao who owns Mac fullscreen

[scheib, 2012-06-20 16:20:34]

http://codereview.chromium.org/10573003/diff/1/chrome/browser/ui/cocoa/fullsc...
File chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm (left):

http://codereview.chromium.org/10573003/diff/1/chrome/browser/ui/cocoa/fullsc...
chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm:95: [self
hideSoon];
On 2012/06/20 15:52:11, Nico wrote:
> Why is this no longer necessary? (This is the bubble fade out animation,
right?)

OnAcceptFullscreenPermission destroys this object. The new bubble that displays
exit instructions and fades out has hideSoon called in showWindow on line 119.

The philosophy is to avoid having this controller duplicating state transitions
that are owned by the FullscreenController. Instead, this controller should show
any state FullscreenController dictates.

[Nico, 2012-06-20 16:23:36]

http://codereview.chromium.org/10573003/diff/1/chrome/browser/ui/cocoa/fullsc...
File chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm (left):

http://codereview.chromium.org/10573003/diff/1/chrome/browser/ui/cocoa/fullsc...
chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm:95: [self
hideSoon];
On 2012/06/20 16:20:34, scheib wrote:
> On 2012/06/20 15:52:11, Nico wrote:
> > Why is this no longer necessary? (This is the bubble fade out animation,
> right?)
> 
> OnAcceptFullscreenPermission destroys this object. The new bubble that
displays
> exit instructions and fades out has hideSoon called in showWindow on line 119.
> 
> The philosophy is to avoid having this controller duplicating state
transitions
> that are owned by the FullscreenController. Instead, this controller should
show
> any state FullscreenController dictates.

Right, but it could reuse the view. That way it's less likely to have a flicker
frame due to no bubble being visible for one frame.

But lgtm anyway.

[scheib, 2012-06-20 16:29:12]

http://codereview.chromium.org/10573003/diff/1/chrome/browser/ui/cocoa/fullsc...
File chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm (left):

http://codereview.chromium.org/10573003/diff/1/chrome/browser/ui/cocoa/fullsc...
chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm:95: [self
hideSoon];
On 2012/06/20 16:23:36, Nico wrote:
> On 2012/06/20 16:20:34, scheib wrote:
> > On 2012/06/20 15:52:11, Nico wrote:
> > > Why is this no longer necessary? (This is the bubble fade out animation,
> > right?)
> > 
> > OnAcceptFullscreenPermission destroys this object. The new bubble that
> displays
> > exit instructions and fades out has hideSoon called in showWindow on line
119.
> > 
> > The philosophy is to avoid having this controller duplicating state
> transitions
> > that are owned by the FullscreenController. Instead, this controller should
> show
> > any state FullscreenController dictates.
> 
> Right, but it could reuse the view. That way it's less likely to have a
flicker
> frame due to no bubble being visible for one frame.
> 
> But lgtm anyway.

The previous behavior:
- Bubble appears with buttons.
- Click a button.
- Bubble flickers aprox 2 frames as it resizes and lays out into a new bubble
without buttons and with different text.
- Bubble times out and slides off screen.

New behavior:
- Bubble appears with buttons.
- Click a button.
- Bubble instantly disappears and a new bubble rapidly slides down to the same
location without buttons and with different text.
- Bubble times out and slides off screen.