Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller.mm

Issue 10573003: Simplify fullscreen exit bubble on mac; updating always creates one freshly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_controller.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller.mm b/chrome/browser/ui/cocoa/browser_window_controller.mm
index b1fb309e22d86cf58fdf6ceec72405da17bdc286..cc443d826d4d7acc27508c3efe342371cf185db2 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller.mm
@@ -1982,16 +1982,7 @@ willAnimateFromState:(bookmarks::VisualState)oldState
bubbleType:(FullscreenExitBubbleType)bubbleType {
fullscreenUrl_ = url;
fullscreenBubbleType_ = bubbleType;
- if (bubbleType == FEB_TYPE_NONE ||
- bubbleType == FEB_TYPE_BROWSER_FULLSCREEN_EXIT_INSTRUCTION) {
- // Show no exit instruction bubble on Mac when in Browser Fullscreen.
- [self destroyFullscreenExitBubbleIfNecessary];
- } else {
- if (!fullscreenExitBubbleController_.get()) {
- [self showFullscreenExitBubbleIfNecessary];
- }
- [fullscreenExitBubbleController_.get() updateURL:url bubbleType:bubbleType];
- }
+ [self showFullscreenExitBubbleIfNecessary];
}
- (BOOL)isFullscreen {

Powered by Google App Engine
This is Rietveld 408576698