Issue 10572007: Revert 142671 - Use WebFrame::replaceMisspelledRange() to replace a misspelled range with text.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10572007: Revert 142671 - Use WebFrame::replaceMisspelledRange() to replace a misspelled range with text. (Closed)

Created:
8 years, 6 months ago by Robert Sesek

Modified:
8 years, 6 months ago

Reviewers:
Hironori Bono

CC:
chromium-reviews, darin-cc_chromium.org, Avi (use Gerrit), ajwong+watch_chromium.org, creis+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 142671 - Use WebFrame::replaceMisspelledRange() to replace a misspelled range with text. Broke spellchecking on Mac (http://crbug.com/133400) If a page has a selection, RenderView::OnReplace() replaces the selection with the given text. To prevent this problem, this change uses a new WebKit API WebFrame::replaceMisspelledRange() that replaces only a misspelled word with the given text. BUG=132941 TEST=none Review URL: https://chromiumcodereview.appspot.com/10536190 TBR=hbono@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=142857

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -23 lines)			Patch
M	chrome/browser/tab_contents/spelling_menu_observer.cc	View	3 chunks	+3 lines, -7 lines	0 comments	Download
M	chrome/common/spellcheck_messages.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/renderer/spellchecker/spellcheck_provider.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/renderer/spellchecker/spellcheck_provider.cc	View	2 chunks	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Robert Sesek

Because we're branching for M21 tonight, Karen suggsted reverting this.

8 years, 6 months ago (2012-06-18 23:27:45 UTC) #2

Hironori Bono

8 years, 6 months ago (2012-06-19 00:36:17 UTC) #3

LGTM.
Apologies for this problem. I have landed this change before WebKit r120586 is
merged to Chromium and it caused this problem.

Regards,

Hironori Bono

Expand Messages | Collapse Messages