Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 10536190: Use WebFrame::replaceMisspelledRange() to replace a misspelled range with text. (Closed)

Created:
8 years, 6 months ago by Hironori Bono
Modified:
8 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, Avi (use Gerrit), ajwong+watch_chromium.org, creis+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Use WebFrame::replaceMisspelledRange() to replace a misspelled range with text. If a page has a selection, RenderView::OnReplace() replaces the selection with the given text. To prevent this problem, this change uses a new WebKit API WebFrame::replaceMisspelledRange() that replaces only a misspelled word with the given text. BUG=132941 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142671

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -3 lines) Patch
M chrome/browser/tab_contents/spelling_menu_observer.cc View 1 3 chunks +7 lines, -3 lines 0 comments Download
M chrome/common/spellcheck_messages.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_provider.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_provider.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Hironori Bono
Greetings Avi and Morita-san, Thanks for your review and helpful comments. I would like to ...
8 years, 6 months ago (2012-06-15 08:05:12 UTC) #1
Hajime Morrita
lgtm. The change looks simple enough.
8 years, 6 months ago (2012-06-15 08:11:20 UTC) #2
Avi (use Gerrit)
lgtm with fix http://codereview.chromium.org/10536190/diff/1/chrome/renderer/spellchecker/spellcheck_provider.h File chrome/renderer/spellchecker/spellcheck_provider.h (right): http://codereview.chromium.org/10536190/diff/1/chrome/renderer/spellchecker/spellcheck_provider.h#newcode80 chrome/renderer/spellchecker/spellcheck_provider.h:80: // Replaces the misspelling range that ...
8 years, 6 months ago (2012-06-15 14:36:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hbono@chromium.org/10536190/9001
8 years, 6 months ago (2012-06-18 03:41:47 UTC) #4
Hironori Bono
Greetings Avi and Morita-san, Many thanks for your review and comments. I have fixed a ...
8 years, 6 months ago (2012-06-18 03:43:59 UTC) #5
commit-bot: I haz the power
8 years, 6 months ago (2012-06-18 05:22:21 UTC) #6
Change committed as 142671

Powered by Google App Engine
This is Rietveld 408576698