Issue 10565008: Add support to keep file-level comment in a .isolate file when merging.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10565008: Add support to keep file-level comment in a .isolate file when merging. (Closed)

Created:
8 years, 6 months ago by M-A Ruel

Modified:
8 years, 6 months ago

Reviewers:
cmp

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add support to keep file-level comment in a .isolate file when merging. So the copyright header doesn't need to be copy-pasted constantly. Add --output so an input file can be overidden with the output. R=cmp@chromium.org NOTRY=true BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142891

Patch Set 1 #

Patch Set 2 : Fix merge_isolate.py #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+81 lines, -27 lines)			Patch
M	tools/isolate/isolate.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/isolate/merge_isolate.py	View	1	7 chunks	+39 lines, -12 lines	0 comments	Download
M	tools/isolate/merge_isolate_test.py	View		8 chunks	+41 lines, -14 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

Address TODOs B) and C) from https://chromiumcodereview.appspot.com/10559009/.

8 years, 6 months ago (2012-06-15 19:42:39 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10565008/3001

8 years, 6 months ago (2012-06-19 01:51:40 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10565008/3001

8 years, 6 months ago (2012-06-19 01:54:35 UTC) #4

Change committed as 142891

Expand Messages | Collapse Messages