Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 1056493002: gbm: make NativePixmap RefCountedThreadSafe (Closed)

Created:
5 years, 8 months ago by dshwang
Modified:
5 years, 8 months ago
Reviewers:
reveman, spang
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gbm: make NativePixmap RefCountedThreadSafe NativePixmap is created/deleted in IO thread and used in main thread to create GL Image. So NativePixmap must be thread safe ref counted. BUG=472610 Committed: https://crrev.com/cde2551f434c89651e7a1a739f90dfcedf9d4b29 Cr-Commit-Position: refs/heads/master@{#323234}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M ui/ozone/public/native_pixmap.h View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
dshwang
reveman@, could you review as zero/one-copy expert? spang@, could you review as owner?
5 years, 8 months ago (2015-04-01 12:34:30 UTC) #2
reveman
Do we need to modify the ref count on the main thread? If that's not ...
5 years, 8 months ago (2015-04-01 13:37:00 UTC) #3
dshwang
On 2015/04/01 13:37:00, reveman wrote: > Do we need to modify the ref count on ...
5 years, 8 months ago (2015-04-01 14:10:32 UTC) #4
reveman
lgtm
5 years, 8 months ago (2015-04-01 14:24:26 UTC) #5
spang
lgtm
5 years, 8 months ago (2015-04-01 14:27:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1056493002/1
5 years, 8 months ago (2015-04-01 14:28:05 UTC) #10
dshwang
On 2015/04/01 14:27:46, spang wrote: > lgtm thx for reviewing!
5 years, 8 months ago (2015-04-01 14:28:07 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-01 14:30:58 UTC) #12
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 14:31:40 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cde2551f434c89651e7a1a739f90dfcedf9d4b29
Cr-Commit-Position: refs/heads/master@{#323234}

Powered by Google App Engine
This is Rietveld 408576698