Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: chrome/browser/resources/help/help.js

Issue 10562042: WebUI: Pass an empty parameter list to invocations of chrome.send.bind. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/resources/downloads/downloads.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 <include src="../uber/uber_utils.js"> 5 <include src="../uber/uber_utils.js">
6 6
7 cr.define('help', function() { 7 cr.define('help', function() {
8 /** 8 /**
9 * Encapsulated handling of the help page. 9 * Encapsulated handling of the help page.
10 */ 10 */
(...skipping 17 matching lines...) Expand all
28 $('product-license').innerHTML = loadTimeData.getString('productLicense'); 28 $('product-license').innerHTML = loadTimeData.getString('productLicense');
29 if (cr.isChromeOS) { 29 if (cr.isChromeOS) {
30 $('product-os-license').innerHTML = 30 $('product-os-license').innerHTML =
31 loadTimeData.getString('productOsLicense'); 31 loadTimeData.getString('productOsLicense');
32 } 32 }
33 33
34 var productTOS = $('product-tos'); 34 var productTOS = $('product-tos');
35 if (productTOS) 35 if (productTOS)
36 productTOS.innerHTML = loadTimeData.getString('productTOS'); 36 productTOS.innerHTML = loadTimeData.getString('productTOS');
37 37
38 $('get-help').onclick = chrome.send.bind(chrome, 'openHelpPage'); 38 $('get-help').onclick = chrome.send.bind(chrome, 'openHelpPage', []);
39 $('report-issue').onclick = 39 $('report-issue').onclick =
40 chrome.send.bind(chrome, 'openFeedbackDialog'); 40 chrome.send.bind(chrome, 'openFeedbackDialog', []);
41 41
42 this.maybeSetOnClick_($('more-info-expander'), 42 this.maybeSetOnClick_($('more-info-expander'),
43 this.toggleMoreInfo_.bind(this)); 43 this.toggleMoreInfo_.bind(this));
44 44
45 this.maybeSetOnClick_($('promote'), 45 this.maybeSetOnClick_($('promote'),
46 chrome.send.bind(chrome, 'promoteUpdater')); 46 chrome.send.bind(chrome, 'promoteUpdater', []));
47 this.maybeSetOnClick_($('relaunch'), 47 this.maybeSetOnClick_($('relaunch'),
48 chrome.send.bind(chrome, 'relaunchNow')); 48 chrome.send.bind(chrome, 'relaunchNow', []));
49 49
50 var channelChanger = $('channel-changer'); 50 var channelChanger = $('channel-changer');
51 if (channelChanger) { 51 if (channelChanger) {
52 var self = this; 52 var self = this;
53 channelChanger.onchange = function(event) { 53 channelChanger.onchange = function(event) {
54 self.setReleaseChannel_(event.target.value); 54 self.setReleaseChannel_(event.target.value);
55 } 55 }
56 } 56 }
57 57
58 // Attempt to update. 58 // Attempt to update.
(...skipping 225 matching lines...) Expand 10 before | Expand all | Expand 10 after
284 HelpPage: HelpPage 284 HelpPage: HelpPage
285 }; 285 };
286 }); 286 });
287 287
288 /** 288 /**
289 * onload listener to initialize the HelpPage. 289 * onload listener to initialize the HelpPage.
290 */ 290 */
291 window.onload = function() { 291 window.onload = function() {
292 help.HelpPage.getInstance().initialize(); 292 help.HelpPage.getInstance().initialize();
293 }; 293 };
OLDNEW
« no previous file with comments | « chrome/browser/resources/downloads/downloads.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698