Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 10562042: WebUI: Pass an empty parameter list to invocations of chrome.send.bind. (Closed)

Created:
8 years, 6 months ago by James Hawkins
Modified:
8 years, 6 months ago
Reviewers:
csilv
CC:
chromium-reviews, asanka, arv (Not doing code reviews), Randy Smith (Not in Mondays)
Visibility:
Public.

Description

WebUI: Pass an empty parameter list to invocations of chrome.send.bind. The bindings code doesn't help us out here and crashes in a DCHECK. BUG=none TEST=none R=csilv Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=142820

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/browser/resources/downloads/downloads.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/help/help.js View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
James Hawkins
8 years, 6 months ago (2012-06-18 18:31:56 UTC) #1
csilv
8 years, 6 months ago (2012-06-18 18:33:36 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698