Introduce HLocalValue and HLocalGet/Set.

lib/compiler/implementation/ssa/variable_allocator.dart

Index: lib/compiler/implementation/ssa/variable_allocator.dart
diff --git a/lib/compiler/implementation/ssa/variable_allocator.dart b/lib/compiler/implementation/ssa/variable_allocator.dart
index fc01e86d8de5938ea7ebb1f5da57b40c8e7cb450..fca59859946cf44839cbdadc587ac7dbb87aaa88 100644
--- a/lib/compiler/implementation/ssa/variable_allocator.dart
+++ b/lib/compiler/implementation/ssa/variable_allocator.dart
@@ -285,8 +285,8 @@ class SsaLiveIntervalBuilder extends HBaseVisitor {
     });
 
     env.removeLoopMarker(header);
-   
-    // Update all liveIns set to contain the liveIns of [header]. 
+
+    // Update all liveIns set to contain the liveIns of [header].
     liveInstructions.forEach((HBasicBlock block, LiveEnvironment other) {
       if (other.loopMarkers.containsKey(header)) {
         env.liveInstructions.forEach((HInstruction instruction, int id) {
@@ -563,10 +563,10 @@ class SsaVariableAllocator extends HBaseVisitor {
    */
   bool needsName(HInstruction instruction) {
     if (instruction.usedBy.isEmpty()) return false;
-    // TODO(ngeoffray): parameters are being generated at use site,
+    // TODO(ngeoffray): locals/parameters are being generated at use site,
     // but we need a name for parameters. We should probably not make

[kasperl, 2012/06/19 11:19:45]

parameters -> them

[floitsch, 2012/06/19 11:31:33]

Done.

     // them generate at use site to make things simpler.
-    if (instruction is HParameterValue && instruction is !HThis) return true;
+    if (instruction is HLocalValue && instruction is !HThis) return true;
     if (generateAtUseSite.contains(instruction)) return false;
     // A [HCheck] instruction that has control flow needs a name only if its
     // checked input needs a name (e.g. a check [HConstant] does not