Introduce HLocalValue and HLocalGet/Set.

lib/compiler/implementation/ssa/variable_allocator.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * The [LiveRange] class covers a range where an instruction is live.
  */
 class LiveRange {
   final int start;
   // [end] is not final because it can be updated due to loops.
@@ skipping 267 matching lines @@
     // Update all instructions that are liveIns in [header] to have a
     // range that covers the loop.
     env.liveInstructions.forEach((HInstruction instruction, int id) {
       LiveInterval range = env.liveIntervals.putIfAbsent(
           instruction, () => new LiveInterval());
       range.loopUpdate(env.startId, lastId);
       env.liveInstructions[instruction] = lastId;
     });
 
     env.removeLoopMarker(header);
-   
-    // Update all liveIns set to contain the liveIns of [header]. 
+
+    // Update all liveIns set to contain the liveIns of [header].
     liveInstructions.forEach((HBasicBlock block, LiveEnvironment other) {
       if (other.loopMarkers.containsKey(header)) {
         env.liveInstructions.forEach((HInstruction instruction, int id) {
           other.liveInstructions[instruction] = id;
         });
         other.removeLoopMarker(header);
         env.loopMarkers.forEach((k, v) { other.loopMarkers[k] = v; });
       }
     });
   }
@@ skipping 256 matching lines @@
       handleInstruction(instruction, namer);
     });
   }
 
   /**
    * Returns whether [instruction] needs a name. Instructions that
    * have no users or that are generated at use site does not need a name.
    */
   bool needsName(HInstruction instruction) {
     if (instruction.usedBy.isEmpty()) return false;
-    // TODO(ngeoffray): parameters are being generated at use site,
+    // TODO(ngeoffray): locals/parameters are being generated at use site,
     // but we need a name for parameters. We should probably not make

[kasperl, 2012/06/19 11:19:45]

parameters -> them

[floitsch, 2012/06/19 11:31:33]

Done.

     // them generate at use site to make things simpler.
-    if (instruction is HParameterValue && instruction is !HThis) return true;
+    if (instruction is HLocalValue && instruction is !HThis) return true;
     if (generateAtUseSite.contains(instruction)) return false;
     // A [HCheck] instruction that has control flow needs a name only if its
     // checked input needs a name (e.g. a check [HConstant] does not
     // need a name).
     if (instruction is HCheck && instruction.isControlFlow()) {
       HCheck check = instruction;
       return needsName(instruction.checkedInput);
     }
     return true;
   }
@@ skipping 32 matching lines @@
       if (!needsName(input)) {
         names.addAssignment(predecessor, input, phi);
       } else {
         names.addCopy(predecessor, input, phi);
       }
     }
 
     namer.allocateName(phi);
   }
 }