Issue 10560027: Improve handling of ArrayBuffers in composite objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10560027: Improve handling of ArrayBuffers in composite objects. (Closed)

Created:
8 years, 6 months ago by Garret Kelly

Modified:
8 years, 6 months ago

Reviewers:
bryeung, sadrul

CC:
chromium-reviews, pam+watch_chromium.org, Aaron Boodman, mihaip-chromium-reviews_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Improve handling of ArrayBuffers in composite objects. Improves json_schema_compiler's understanding of what an ArrayBuffer should be stored as in the native generated code. This change also improves the validation of ArrayBuffer fields in argument objects. BUG=133178 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142621

Patch Set 1 #

Patch Set 2 : Fixing tests. #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -5 lines)			Patch
M	chrome/renderer/resources/extensions/json_schema.js	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tools/json_schema_compiler/cc_generator.py	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	tools/json_schema_compiler/cpp_type_generator.py	View		2 chunks	+6 lines, -1 line	0 comments	Download
M	tools/json_schema_compiler/idl_schema.py	View		1 chunk	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...

8 years, 6 months ago (2012-06-16 20:36:55 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gdk@chromium.org/10560027/6001

8 years, 6 months ago (2012-06-16 20:56:08 UTC) #4

Change committed as 142621

Expand Messages | Collapse Messages