tools/json_schema_compiler/cc_generator.py - Issue 10560027: Improve handling of ArrayBuffers in composite objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/json_schema_compiler/cc_generator.py

Issue 10560027: Improve handling of ArrayBuffers in composite objects. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixing tests. Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/json_schema_compiler/cc_generator.py

diff --git a/tools/json_schema_compiler/cc_generator.py b/tools/json_schema_compiler/cc_generator.py

index 7b3e902aa93b806a0d6af6a5fbb237806fe3391c..3bba684b21e9ace38fa7a5385447566504015c7d 100644

--- a/tools/json_schema_compiler/cc_generator.py

+++ b/tools/json_schema_compiler/cc_generator.py

@@ -345,6 +345,8 @@ class CCGenerator(object):

return '%s.DeepCopy()' % var

elif prop.type_ == PropertyType.ENUM:

return 'CreateEnumValue(%s).release()' % var

+ elif prop.type_ == PropertyType.BINARY:

+ return '%s->DeepCopy()' % var

elif self._IsArrayOrArrayRef(prop):

return '%s.release()' % self._util_cc_helper.CreateValueFromArray(

self._cpp_type_generator.GetReferencedProperty(prop), var,