Replace all spaces by '_' in the AppUserModelId

chrome/installer/util/shell_util.cc

Index: chrome/installer/util/shell_util.cc
diff --git a/chrome/installer/util/shell_util.cc b/chrome/installer/util/shell_util.cc
index 229abe52f79b9b56664f144c7750c697bdd8306b..0970db23d6962312f98b5e591aba594bbe66349f 100644
--- a/chrome/installer/util/shell_util.cc
+++ b/chrome/installer/util/shell_util.cc
@@ -1116,8 +1116,10 @@ string16 ShellUtil::BuildAppModelId(
     if (it != components.begin())
       app_id.push_back(L'.');
 
-    const string16& component = *it;
+    string16 component = *it;
     DCHECK(!component.empty());
+    // No spaces are allowed in the AppUserModelId according to MSDN.
+    ReplaceChars(component, L" ", L"_", &component);

[robertshield, 2012/06/20 21:50:16]

could you do this replacement at the end of the loop on the app_id string?

[gab, 2012/06/20 21:58:36]

Done.

     if (component.length() > max_component_length) {
       // Append a shortened version of this component. Cut in the middle to try
       // to avoid losing the unique parts of this component (which are usually