Replace all spaces by '_' in the AppUserModelId

chrome/installer/util/shell_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file defines functions that integrate Chrome in Windows shell. These
 // functions can be used by Chrome as well as Chrome installer. All of the
 // work is done by the local functions defined in anonymous namespace in
 // this class.
 
 #include "chrome/installer/util/shell_util.h"
@@ skipping 1098 matching lines @@
     return (*components.begin()).substr(0, installer::kMaxAppModelIdLength);
   }
 
   string16 app_id;
   app_id.reserve(installer::kMaxAppModelIdLength);
   for (std::vector<string16>::const_iterator it = components.begin();
        it != components.end(); ++it) {
     if (it != components.begin())
       app_id.push_back(L'.');
 
-    const string16& component = *it;
+    string16 component = *it;
     DCHECK(!component.empty());
+    // No spaces are allowed in the AppUserModelId according to MSDN.
+    ReplaceChars(component, L" ", L"_", &component);

[robertshield, 2012/06/20 21:50:16]

could you do this replacement at the end of the loop on the app_id string?

[gab, 2012/06/20 21:58:36]

Done.

     if (component.length() > max_component_length) {
       // Append a shortened version of this component. Cut in the middle to try
       // to avoid losing the unique parts of this component (which are usually
       // at the beginning or end for things like usernames and paths).
       app_id.append(component.c_str(), 0, max_component_length / 2);
       app_id.append(component.c_str(),
                     component.length() - ((max_component_length + 1) / 2),
                     string16::npos);
     } else {
       app_id.append(component);
@@ skipping 380 matching lines @@
       chrome_exe.c_str(),
       shortcut.c_str(),
       chrome_path.value().c_str(),
       arguments.c_str(),
       description.c_str(),
       icon_path.c_str(),
       icon_index,
       app_id.c_str(),
       ConvertShellUtilShortcutOptionsToFileUtil(options));
 }