Issue 10559068: Add CustomEvent.initCustomEvent test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10559068: Add CustomEvent.initCustomEvent test. (Closed)

Created:
8 years, 6 months ago by Anton Muhin

Modified:
8 years, 6 months ago

Reviewers:
podivilov, sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add CustomEvent.initCustomEvent test. R=podivilov@chromium.org,sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=8906

Patch Set 1 #

Total comments: 4

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -0 lines)			Patch
	A	tests/html/event_customevent_test.dart	View		1 chunk	+36 lines, -0 lines	4 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

podivilov

lgtm https://chromiumcodereview.appspot.com/10559068/diff/1/tests/html/event_customevent_test.dart File tests/html/event_customevent_test.dart (right): https://chromiumcodereview.appspot.com/10559068/diff/1/tests/html/event_customevent_test.dart#newcode10 tests/html/event_customevent_test.dart:10: // TODO(nweiz): Make this private to testEvents when ...

8 years, 6 months ago (2012-06-20 11:56:50 UTC) #2

Anton Muhin

8 years, 6 months ago (2012-06-20 13:18:22 UTC) #3

https://chromiumcodereview.appspot.com/10559068/diff/1/tests/html/event_custo...
File tests/html/event_customevent_test.dart (right):

https://chromiumcodereview.appspot.com/10559068/diff/1/tests/html/event_custo...
tests/html/event_customevent_test.dart:10: // TODO(nweiz): Make this private to
testEvents when Frog supports closures with
On 2012/06/20 11:56:50, podivilov wrote:
> Frog? :)

Copy paste. Hmm, do not know, I'd rather nuke the comment itself.

https://chromiumcodereview.appspot.com/10559068/diff/1/tests/html/event_custo...
tests/html/event_customevent_test.dart:35: (ev) { expect(ev.detail,
equals('detail')); });
On 2012/06/20 11:56:50, podivilov wrote:
> nit: =>

Alas, I hate it myself, but => foo() is a bad idea if foo is void and expect is
:(

Expand Messages | Collapse Messages