Issue 10559063: Teach grokdump to print oddball kind when ToString content is not available

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10559063: Teach grokdump to print oddball kind when ToString content is not available (Closed)

Created:
8 years, 6 months ago by Vyacheslav Egorov (Google)

Modified:
8 years, 6 months ago

Reviewers:
Michael Starzinger, danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Teach grokdump to print oddball kind when ToString content is not available R=danno@chromium.org BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=11856

Patch Set 1 #

Total comments: 1

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -1 line)			Patch
	M	tools/grokdump.py	View		2 chunks	+21 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

8 years, 6 months ago (2012-06-19 11:38:35 UTC) #2

LGTM (with one nit).

https://chromiumcodereview.appspot.com/10559063/diff/1/tools/grokdump.py
File tools/grokdump.py (right):

https://chromiumcodereview.appspot.com/10559063/diff/1/tools/grokdump.py#newc...
tools/grokdump.py:1053: ODDBALL_KINDS = [
Can we move that into the "Oddball" class?

Expand Messages | Collapse Messages