Teach grokdump to print oddball kind when ToString content is not available

tools/grokdump.py

 #!/usr/bin/env python
 #
 # Copyright 2012 the V8 project authors. All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 #       notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
@@ skipping 1031 matching lines @@
     String.__init__(self, heap, map, address)
     self.left = self.ObjectField(self.LeftOffset())
     self.right = self.ObjectField(self.RightOffset())
 
   def GetChars(self):
     try:
       return self.left.GetChars() + self.right.GetChars()
     except:
       return "***CAUGHT EXCEPTION IN GROKDUMP***"
 
+# Should match declarations in objects.h
+ODDBALL_KINDS = [

[Michael Starzinger, 2012/06/19 11:38:35]

Can we move that into the "Oddball" class?

+  "False",
+  "True",
+  "TheHole",
+  "Null",
+  "ArgumentMarker",
+  "Undefined",
+  "Other"
+]
 
 class Oddball(HeapObject):
   def ToStringOffset(self):
     return self.heap.PointerSize()
 
+  def ToNumberOffset(self):
+    return self.ToStringOffset() + self.heap.PointerSize()
+
+  def KindOffset(self):
+    return self.ToNumberOffset() + self.heap.PointerSize()
+
   def __init__(self, heap, map, address):
     HeapObject.__init__(self, heap, map, address)
     self.to_string = self.ObjectField(self.ToStringOffset())
+    self.kind = self.SmiField(self.KindOffset())
 
   def Print(self, p):
     p.Print(str(self))
 
   def __str__(self):
     if self.to_string:
       return "Oddball(%08x, <%s>)" % (self.address, self.to_string.GetChars())
     else:
-      return "Oddball(%08x, kind=%s)" % (self.address, "???")
+      kind = "???"
+      if 0 <= self.kind < len(ODDBALL_KINDS):
+        kind = ODDBALL_KINDS[self.kind]
+      return "Oddball(%08x, kind=%s)" % (self.address, kind)
 
 
 class FixedArray(HeapObject):
   def LengthOffset(self):
     return self.heap.PointerSize()
 
   def ElementsOffset(self):
     return self.heap.PointerSize() * 2
 
   def __init__(self, heap, map, address):
@@ skipping 573 matching lines @@
   parser = optparse.OptionParser(USAGE)
   parser.add_option("-s", "--shell", dest="shell", action="store_true",
                     help="start an interactive inspector shell")
   parser.add_option("-f", "--full", dest="full", action="store_true",
                     help="dump all information contained in the minidump")
   options, args = parser.parse_args()
   if len(args) != 1:
     parser.print_help()
     sys.exit(1)
   AnalyzeMinidump(options, args[0])