chrome/browser/extensions/extension_preference_apitest.cc - Issue 10559052: Split mode incognito extension can get misleading pref changed events from regular mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_preference_apitest.cc

Issue 10559052: Split mode incognito extension can get misleading pref changed events from regular mode (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Deleted commented-out lines in extension_preference_api.cc Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_pref_value_map_unittest.cc ('k') | chrome/browser/extensions/extension_preference_helpers.cc » ('j') | chrome/test/data/extensions/api_test/preference/onchange/test.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_preference_apitest.cc

diff --git a/chrome/browser/extensions/extension_preference_apitest.cc b/chrome/browser/extensions/extension_preference_apitest.cc

index 59ffdcd09ed3d70a2a5907d369f35ef8c19abbdc..72e9f1e4df51a8939908cbbe7502e9b7e2323132 100644

--- a/chrome/browser/extensions/extension_preference_apitest.cc

+++ b/chrome/browser/extensions/extension_preference_apitest.cc

@@ -110,9 +110,6 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, PreferenceClear) {

}

IN_PROC_BROWSER_TEST_F(ExtensionApiTest, PreferenceOnChange) {

- PrefService* prefs = browser()->profile()->GetPrefs();

- prefs->SetBoolean(prefs::kBlockThirdPartyCookies, false);

EXPECT_TRUE(RunExtensionTestIncognito("preference/onchange")) <<

message_;

}