chrome/browser/extensions/extension_preference_apitest.cc - Issue 10559052: Split mode incognito extension can get misleading pref changed events from regular mode

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/extension_preference_apitest.cc

Issue 10559052: Split mode incognito extension can get misleading pref changed events from regular mode (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Deleted commented-out lines in extension_preference_api.cc Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/extensions/extension_pref_value_map_unittest.cc ('k') | chrome/browser/extensions/extension_preference_helpers.cc » ('j') | chrome/test/data/extensions/api_test/preference/onchange/test.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/utf_string_conversions.h"	5 #include "base/utf_string_conversions.h"

6 #include "chrome/browser/extensions/extension_apitest.h"	6 #include "chrome/browser/extensions/extension_apitest.h"

7 #include "chrome/browser/prefs/pref_service.h"	7 #include "chrome/browser/prefs/pref_service.h"

8 #include "chrome/browser/profiles/profile.h"	8 #include "chrome/browser/profiles/profile.h"

9 #include "chrome/browser/ui/browser.h"	9 #include "chrome/browser/ui/browser.h"

10 #include "chrome/common/chrome_switches.h"	10 #include "chrome/common/chrome_switches.h"

(...skipping 92 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
103 EXPECT_TRUE(RunExtensionTest("preference/clear")) << message_;	103 EXPECT_TRUE(RunExtensionTest("preference/clear")) << message_;

104	104

105 const PrefService::Preference* pref = pref_service->FindPreference(	105 const PrefService::Preference* pref = pref_service->FindPreference(

106 prefs::kBlockThirdPartyCookies);	106 prefs::kBlockThirdPartyCookies);

107 ASSERT_TRUE(pref);	107 ASSERT_TRUE(pref);

108 EXPECT_FALSE(pref->IsExtensionControlled());	108 EXPECT_FALSE(pref->IsExtensionControlled());

109 EXPECT_EQ(true, pref_service->GetBoolean(prefs::kBlockThirdPartyCookies));	109 EXPECT_EQ(true, pref_service->GetBoolean(prefs::kBlockThirdPartyCookies));

110 }	110 }

111	111

112 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, PreferenceOnChange) {	112 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, PreferenceOnChange) {

113 PrefService* prefs = browser()->profile()->GetPrefs();

114 prefs->SetBoolean(prefs::kBlockThirdPartyCookies, false);

115

116 EXPECT_TRUE(RunExtensionTestIncognito("preference/onchange")) <<	113 EXPECT_TRUE(RunExtensionTestIncognito("preference/onchange")) <<

117 message_;	114 message_;

118 }	115 }

OLD	NEW